There are more than one committers in a project. If such merge is really urgent, PTL can just pick up phone and work with other committers. I am sure other committers will be reasonable and cooperative to help merge this type of change (e.g. one line in a pom.xml) immediately.
Do you have precedents that because of lack of this change, any business was delayed significantly that caused irrecoverable damage to community? On the other hand, this can be easily abused as many of us concerned, and can easily go out of control. For example, while some key feature or key code are still under review, and there are different options from community members, PTL could abuse this power and merge their own spec/code by claiming “effective and speed up process for delivery”. Another case is that PTL can claim the code of their colleagues are theirs, and abuse the power for the items that are under review. I do have a case of how PTL abused power to block other company’s legitimate work request with misrepresented information. Thanks Bin From: onap-tsc-boun...@lists.onap.org [mailto:onap-tsc-boun...@lists.onap.org] On Behalf Of Gildas Lanilis Sent: Sunday, March 18, 2018 2:27 PM To: GILBERT, MAZIN E <ma...@research.att.com>; Kenny Paul <kp...@linuxfoundation.org> Cc: onap-tsc@lists.onap.org P <onap-tsc@lists.onap.org> Subject: Re: [onap-tsc] Community Announcement- PTL Self Code Merge Vote I think we should highlight the specific circumstances that were brought up by PTLs during TSC meeting last Thursday. In normal circumstances, PTLs agreed they must not merged their own code. However, in circumstances such as just editing one line in a pom.xml file to change the version on a dependency, the PTL would made the merge. In such case a code review is not necessary, the goal in mind is to be effective and speed up process of delivering. We need to trust our PTLs. As anything we all do is public, I would like to believe good citizenship will prevail. Thanks, Gildas ONAP Release Manager 1 415 238 6287 From: onap-tsc-boun...@lists.onap.org<mailto:onap-tsc-boun...@lists.onap.org> [mailto:onap-tsc-boun...@lists.onap.org] On Behalf Of GILBERT, MAZIN E (MAZIN E) Sent: Saturday, March 17, 2018 4:53 AM To: Kenny Paul <kp...@linuxfoundation.org<mailto:kp...@linuxfoundation.org>> Cc: onap-tsc@lists.onap.org<mailto:onap-tsc@lists.onap.org> P <onap-tsc@lists.onap.org<mailto:onap-tsc@lists.onap.org>> Subject: Re: [onap-tsc] Community Announcement- PTL Self Code Merge Vote But this will give PTLs in other companies the ability to push their own code, or even code from their colleagues that they claim is theirs. This impacts code quality process. I am not very comfortable letting this happen, frankly. On Mar 15, 2018, at 6:30 PM, Kenny Paul <kp...@linuxfoundation.org<mailto:kp...@linuxfoundation.org>> wrote: This is to inform the community that the following item is being forwarded to the TSC for an email vote as per today’s TSC meeting. The TSC approves changing the General Code Commit Rules as documented under Approved Operational Policies<https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.onap.org_display_DW_Approved-2BOperational-2BPolicies&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=cAD_hd8nB7EFlC523Ubj359d3-sy7Yyaow8XBuQWhXE&s=nkA2AHFlGJBmvSbBlADZQSxujmyj0APLr15VUMp4PaY&e=> to allow PTLs merging their own commit provided there is a time critical need and provided that the justification for doing so is documented in the code review comments. THIS IS NOT THE CALL TO VOTE! The formal vote will occur on the onap-tsc-vote alias, not here. A plus-one, minus-one, or zero here on this issue is null and void. Best Regards, -kenny Kenny Paul, Technical Program Manager, The Linux Foundation kp...@linuxfoundation.org<mailto:kp...@linuxfoundation.org>, 510.766.5945 San Francisco Bay Area, Pacific Time Zone _______________________________________________ ONAP-TSC mailing list ONAP-TSC@lists.onap.org<mailto:ONAP-TSC@lists.onap.org> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.onap.org_mailman_listinfo_onap-2Dtsc&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=IKSC5mg8GeOiSar1dax3GQ&m=7zFgm0XTqg3Zx-CI5PQJjIaYUEokDvu_xPWfdYtfc1U&s=E69yU-W3pvKTigIC3quTyF5mmRe3_RQBnjNiohgBzeo&e=
_______________________________________________ ONAP-TSC mailing list ONAP-TSC@lists.onap.org https://lists.onap.org/mailman/listinfo/onap-tsc