I think the focus was to narrow down to “only” PTLs from the current state of ONAP where anyone can merge their own code without any review. Currently we have no enforced rules We are moving to an enforced commit trigger that excepts PTLs – they must post a comment in the gerrit review that this is for emergency build fixing ….etc.
We may want to reword the proposal in reverse. We are going from 0% automated commit oversight to below 100% oversight – where the commit trigger rule skips PTLs – perhaps with a check on a gerrit comment. ? /michael From: onap-tsc-boun...@lists.onap.org [mailto:onap-tsc-boun...@lists.onap.org] On Behalf Of GILBERT, MAZIN E (MAZIN E) Sent: Saturday, March 17, 2018 07:53 To: Kenny Paul <kp...@linuxfoundation.org> Cc: onap-tsc@lists.onap.org P <onap-tsc@lists.onap.org> Subject: Re: [onap-tsc] Community Announcement- PTL Self Code Merge Vote But this will give PTLs in other companies the ability to push their own code, or even code from their colleagues that they claim is theirs. This impacts code quality process. I am not very comfortable letting this happen, frankly. On Mar 15, 2018, at 6:30 PM, Kenny Paul <kp...@linuxfoundation.org<mailto:kp...@linuxfoundation.org>> wrote: This is to inform the community that the following item is being forwarded to the TSC for an email vote as per today’s TSC meeting. The TSC approves changing the General Code Commit Rules as documented under Approved Operational Policies<https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.onap.org_display_DW_Approved-2BOperational-2BPolicies&d=DwMFAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=jwTiArcEj6aUX0HjV0M3dT12gUtk7rC07xpgpVZkS_4&m=cAD_hd8nB7EFlC523Ubj359d3-sy7Yyaow8XBuQWhXE&s=nkA2AHFlGJBmvSbBlADZQSxujmyj0APLr15VUMp4PaY&e=> to allow PTLs merging their own commit provided there is a time critical need and provided that the justification for doing so is documented in the code review comments. THIS IS NOT THE CALL TO VOTE! The formal vote will occur on the onap-tsc-vote alias, not here. A plus-one, minus-one, or zero here on this issue is null and void. Best Regards, -kenny Kenny Paul, Technical Program Manager, The Linux Foundation kp...@linuxfoundation.org<mailto:kp...@linuxfoundation.org>, 510.766.5945 San Francisco Bay Area, Pacific Time Zone _______________________________________________ ONAP-TSC mailing list ONAP-TSC@lists.onap.org<mailto:ONAP-TSC@lists.onap.org> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.onap.org_mailman_listinfo_onap-2Dtsc&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=IKSC5mg8GeOiSar1dax3GQ&m=7zFgm0XTqg3Zx-CI5PQJjIaYUEokDvu_xPWfdYtfc1U&s=E69yU-W3pvKTigIC3quTyF5mmRe3_RQBnjNiohgBzeo&e= This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at https://www.amdocs.com/about/email-disclaimer <https://www.amdocs.com/about/email-disclaimer>
_______________________________________________ ONAP-TSC mailing list ONAP-TSC@lists.onap.org https://lists.onap.org/mailman/listinfo/onap-tsc
