----- Original Message ----- > From: Rob Weir <robw...@apache.org> > To: ooo-dev@incubator.apache.org > Cc: > Sent: Sunday, June 24, 2012 12:21 PM > Subject: Re: CMS diff: Apache OpenOffice (Incubating) > > On Sun, Jun 24, 2012 at 12:13 PM, <robw...@cms.zones.apache.org> wrote: >> Clone URL (Committers only): >> > https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://openofficeorg.apache.org/openofficeorg%2Findex.mdtext >> >> robweir -- testing, no need to apply patch >> > > So getting the patch generated and mailed worked. But when I then > went into my mail and tried to click the clone link, I got an error > about not being able to clone myself. I'm not an expert in bioethics, > but this sounds like a reasonable prohibition ;-) > > Exiting browser and going back in to Gmail fixed the problem. I think > the issue was the browser was caching the CMS authentication for user > anonymous, and I had to clear that first. But this is a weird > scenario, one that would only come up in a demo. Typically the person > making and applying the patch are two different people. > > So overall this looks cool. Two enhancements that would make it even better:
Thanks! > 1) Some static text saying something along the lines of "By clicking > submit you agree to provide this patch under the terms of the Apache > License 2.0 [link]" Seems a bit bureaucratic for my tastes (personally loathe the jira checkbox), but if others see a need perhaps I can do something about it. > > 2) A text box for entering a comment associated with the patch, which > would be inserted into the email. This helps the committer applying > the patch understand what they are looking at, if it is not obvious. My response to that is to avoid using Quick Mail for such cases and just submit your Edit => Diff => Mail Diff, which contains a full textarea for patch commentary. A good tutorial (hint) should discuss the distinction between lightweight changes, for which Quick Mail is suitable, and those more involved, where the "full procedure" is better suited for the task. > > > -Rob > >> Index: /trunk/content/openofficeorg/index.mdtext >> =================================================================== >> --- /trunk/content/openofficeorg/index.mdtext (revision 1353213) >> +++ /trunk/content/openofficeorg/index.mdtext (working copy) >> @@ -7,8 +7,8 @@ >> - [Download Binaries](http://download.openoffice.org) >> >> Apache OpenOffice is comprised of six personal productivity applications: > a word processor (and its web-authoring component), >> -spreadsheet, presentation graphics, drawing, equation editor, and > database. OpenOffice is released on Windows, Solaris, Linux and >> -Macintosh operation systems, with more communities joining, including a > mature FreeBSD port. OpenOffice is localized, supporting >> +spreadsheet, presentation graphics, drawing, equation editor, and > database. OpenOffice is released on Windows, Linux and >> +Macintosh operation systems, with more ports in progress, including > FreeBSD, Solaris and OS/2. OpenOffice is localized, supporting >> over 110 languages worldwide. >> >> OpenOffice.org [was donated] [4] to the Apache Software Foundation (ASF) > on June 1, 2011. As with any code base for consideration >> >
