On Tue, Dec 30, 2008 at 11:15 AM, Rainer Tammer <tam...@tammer.net> wrote:

> there is a little problem with the patch...
> You have unfortunately used the 32 bit part (with the LL):

> #ifndef __INT64_C
>
> #define __INT64_C(c)  c ## L    <----- this is the 64 bit version

Sorry, I wasn't thinking.  I'll change that.

> I think the limitation to __REXX64__ is necessary as this version is only
> for 64 bit.

I don't think it is necessary because the actual use of __INT64_C is
already wrapped with ifdef __REXX64__.

> If you like to add this to rexxplatformdefs.h then it is important that
> rexxplatformdefs.h is
> always included after rexxapitypes.h.

It is always included after rexxapitypes.h

> I think rexxapitypes.h would be a
> safer place.

Rick is the ultimate decider on where things should go.  It wouldn't
be the first time I put something in the wrong place.  <grin>

If he thinks it should be moved, then I will.  I put it there because:
 1.) It is not a type.  2.) Windows uses the same define but with LL
because on Windows 64-bit a long is still 32-bits so long long is
correct.  That makes the define a sort of platform specific define.
Which in turn seems to dictate it should go in rexxplatformdefs.h

--
Mark Miesfeld

------------------------------------------------------------------------------
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to