Hi Rick,
I just made a couple of small changes and your custom target now works.
I don't think I have an objection to using the CPack version.
Earlier today, I was thinking we could drive the installer creation from
CPack by just using a NSIS.template.in file that was a copy of our current
script and copying the files from platform/windows/install to the directory
that NSIS.template.in is copied to.
I'm not sure if that is what you are thinking of, or not.
I'll play around with that and see if I can get it to work.
--
Mark Miesfeld
On Sun, Jun 8, 2014 at 3:19 PM, Rick McGuire <object.r...@gmail.com> wrote:
> Mark,
>
> I've been poking around, and it might actually be possible to still drive
> the install from CMake and still keep the current installer. I've how to
> get access to the install information and it should be possible to inject
> that information into a template install file. This is something for the
> longer term, but this gets by all of your objections to switching to the
> CPack version. The only thing that would change would be the removal of
> the manifest and shortcut information from the .nsi file. Everything else
> would remain the same.
>
> Rick
>
> Rick
>
>
> On Sun, Jun 8, 2014 at 3:44 PM, Rick McGuire <object.r...@gmail.com>
> wrote:
>
>> Mark,
>>
>> I was right, it was pretty easy to add this as a build target (assuming I
>> got the command syntax right). To build the installer, just issue the
>> command "nmake nsis_installer" from the build directory command line. This
>> is setup with dependencies on the doc files being in an indicated directory
>> and is currently assuming the script is platform\windows\cpack.nsi.
>> Hopefully the I have the makensis command syntax correct, but that should
>> be easy to fix.
>>
>> Rick
>>
>>
>> On Sun, Jun 8, 2014 at 2:52 PM, Rick McGuire <object.r...@gmail.com>
>> wrote:
>>
>>> Ok, I guess I'm good with that. Since we need to tweak this a bit, I
>>> suggest we leave oorexx.nsi unchanged and check in a new file to build from
>>> (and I agree, a custom script might not be a bad idea). A batch file is a
>>> good idea here, although I wonder if we can add a to the cmake script that
>>> is not part of the ALL category so that this becomes an NMAKE target we can
>>> invoke from the build directory in question. The cmake script already
>>> knows about the locations for everything, and we can probably build in a
>>> dependency for the doc files so it will refuse to build without the files
>>> there.
>>>
>>> I just checked in a change to the cmake script to copy those additional
>>> class files (and rexxtry) to the bin directory. For test/development
>>> purposes, it makes sense for those to be part of the build.
>>>
>>> Rick
>>>
>>>
>>> On Sun, Jun 8, 2014 at 2:19 PM, Mark Miesfeld <miesf...@gmail.com>
>>> wrote:
>>>
>>>> Sorry I wasn't engaged in this topic earlier. But, I don't agree with
>>>> the approach we've taken with this.
>>>>
>>>> We have a perfectly good NSIS script that produces the NSIS installer
>>>> on Windows. This script has been refined over the years until it is at the
>>>> point it is today.
>>>>
>>>> I think we should just stick with it.
>>>>
>>>> It took me about an hour to get it working with the CPack build. It
>>>> doesn't make any changes to the way the non-CPack NSIS installer worked.
>>>> And most of the time was because the CPack build isn't including some of
>>>> the *.cls files yet. socket.cls, csvStream.cls, etc.. Also there was a
>>>> change to the API samples directory that was included in the the current
>>>> oorexx.nsi script
>>>>
>>>> It is slightly awkward because you need to cd from the build directory
>>>> to the source directory and then run a long command line:
>>>>
>>>> *C:\work.ooRexx\wc\build>cd
>>>> \work.ooRexx\wc\main\platform\windows\install*
>>>>
>>>> *C:\work.ooRexx\wc\main\platform\windows\install>*
>>>>
>>>> *C:\work.ooRexx\wc\main\platform\windows\install>makensis
>>>> /DVERSION=4.3.0 /DNODOTVER=430 /DSRCDIR=c:\work.ooRexx\wc\m*
>>>> *ain /DBINDIR=C:\work.ooRexx\wc\build\bin /DCPU=x64 cpack.nsi*
>>>>
>>>> That could be fixed with a simple Rexx or .bat script.
>>>>
>>>> Using a CPack generated NSIS script has, I believe, some problems that
>>>> will force the next Windows installer to behave differently.
>>>>
>>>> 1.) We have the bin files being placed in a different directory.
>>>>
>>>> 2.) The CPack NSIS script writes the uninstall information to a
>>>> different registry location. This will be a problem with the automatic
>>>> uninstallation of an existing install. It will also cause problems with
>>>> the "upgrade" option on Windows. Both of these can probably be fixed by
>>>> checking both registry locations. But, still, that is a good bit of added
>>>> work.
>>>>
>>>> I know Rick has put in a lot of time on a CPack generated NSIS script.
>>>> But, I think there is still a lot of time that needs to be spent on it.
>>>>
>>>> I'm in favor of just sticking with our current script.
>>>>
>>>> --
>>>> Mark Miesfeld
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Learn Graph Databases - Download FREE O'Reilly Book
>>>> "Graph Databases" is the definitive new guide to graph databases and
>>>> their
>>>> applications. Written by three acclaimed leaders in the field,
>>>> this first edition is now available. Download your free book today!
>>>> http://p.sf.net/sfu/NeoTech
>>>> _______________________________________________
>>>> Oorexx-devel mailing list
>>>> Oorexx-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>>>
>>>>
>>>
>>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
