On Sun, Feb 7, 2021 at 5:34 PM P.O. Jonsson <oor...@jonases.se> wrote:
> Following Ricks advice I am looking how and where to put the additional > files for the macOS installer in the SVN tree. > > In oorexxSVN/platform/unix/macosx there are 3 files related to the (now > broken) packagemaker for macOS. > > Q1: Can I put macOS specific files there? > Yes, either there, or create a platform/macosx directory. I can make strong arguments either way, but keeping an existing directory probably makes the most sense. There are no other places where we've created subdirectories specifically for macosx. It probably makes sense to consider it a sub-type of a unix OS. For Windows, all files related to the installer are put in platform/windows/install. It might be a good idea to use platform/unix/macos/install Q2: Shall I delete those files that are no longer used? or create a > subdirectory /obsolete? > > svn maintains information for all file deletions, so there's no need to keep old files around. If needed, they can be recovered at any time. Keeping them in the tree just adds noise to the process. Go ahead and delete them. > I also have a question about the ooRexx icon files. I have used a high > resolution (512X512 px) png version of the ooRexx logo to create the icon > file (icns file) for the macOS installer. It is similar to the png files > used here <https://www.oorexx.org/index2.html> (256X256 px png file) and > here <https://github.com/ooRexx> (png file 200X200 px) with the two "O"s > close to each-other. Since I am not sure where I have "my" file from I am > not sure if I can upload it or use it for icon file for the macOS. > Q3: What is the opinion on this? > > If you don't really know the pedigree of the icon you are using, then please don't use it. It should be easy to create a higher res version from existing resources. > I have looked in the SVN tree and in oorexxSVN/platform/unix there is a > low resolution file oorexx.png (48X48 px) used for Unix/Linux RPM and DEB > builds. This png is also referred to in CMakelists.txt in the (obsolete) > Cpack section #Apple macOS. > > Q4: Should this section be emptied? Or can someone clean it up? Who? > Yes, remove anything that no longer applies. As I stated earlier, svn never forgets so those sections can be recovered if they are needed. > > Q5: Should I include the "Package description" from this section of > CMakelists.txt in the Readme files for the installer? > It would be a good idea, if it makes sense. I just checked, and the Windows installer does not include this. Not sure if it is part of the other unix installer packages or not. > > Q6: Shall I include the Copyright Notice in the readme files? > > Yes. A copyright really should be in any plain text files. > Q7: Is the contact mail sahana...@users.sf.net for macOS still correct? > > Probably not. It would be better if a contact email were a project-specific one (perhaps one of the mailing lists) rather than a specific individual. > Any other things that need consideration? > > Does the installer you build also pick up things like release number, etc. from CMake? You might want to take a look at platform/windows/install/ cpack.nsi.template.in to see the types of information the Windows installer pulls in from CMake. Any variable in that file that starts with '@" is information that is pulled in from cmake.txt file. Rick > Hälsningar/Regards/Grüsse, > P.O. Jonsson > oor...@jonases.se > > > > _______________________________________________ > Oorexx-devel mailing list > Oorexx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/oorexx-devel >
_______________________________________________ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
