> On Sept. 4, 2012, 9:54 p.m., Alejandro Abdelnur wrote: > > IMO, until WFGEN is functional complete we should not include it in distro > > tarball. Also, when we do that, I don't think it should be by default in > > the tomcat server used by Oozie server but in a separate one. Wondering if > > we should have a separate binary tarball for it. thoughts?
>I don't think it should be by default in the tomcat server used by Oozie server yes, totally agree, WFGEN is not currently using tomcat server used by oozie, it is bundled with separate tomcat server for isolation. As it matures in future, we need to think of how to integrate into using the same tomcat server. >Wondering if we should have a separate binary tarball for it there are two final artifacts from WFGEN. one is workflowgenerator-3.3.0-SNAPSHOT-tomcat.tar.gz, which bundles separate tomcat server(not the one used by oozie-server) where workflowgenerator.war file is already placed under /webapps, and the other is workflowgenerator-3.3.0-SNAPSHOT.war, which a user can copy to /webapps of their own tomcat server. I changed top-level pom to include two files(tar.gz and war) in final oozie tarball, to avoid extra effort of maintaining separate tarball only for WFGEN. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6847/#review11035 ----------------------------------------------------------- On Sept. 1, 2012, 5:34 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6847/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2012, 5:34 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-976 > > > This addresses bug OOZIE-976. > https://issues.apache.org/jira/browse/OOZIE-976 > > > Diffs > ----- > > branches/branch-3.3/pom.xml 1379690 > branches/branch-3.3/src/main/assemblies/distro.xml 1379690 > branches/branch-3.3/workflowgenerator/README.txt 1379690 > branches/branch-3.3/workflowgenerator/pom.xml 1379690 > > branches/branch-3.3/workflowgenerator/src/main/assemblies/workflowgenerator.xml > 1379690 > > Diff: https://reviews.apache.org/r/6847/diff/ > > > Testing > ------- > > done locally > > > Thanks, > > Ryota Egashira > >
