On 06/01/2011 09:14 AM, Jan Friesse wrote: > Series of patches to make Flatiron branch pass coverity without any > error. Patches from Angus and Jerome are even backport or directly > cherry picked, because it solves problems found by cov. > > All patches should be pretty straightforward with exception of last > one "crypto: handle overflow in HASH_PROCESS macro." This needs to > be checked (at least) twice. > > Angus Salkeld (2): > remove unused function declaration > testcpg: fix a format string compile warning. > > Jan Friesse (17): > totemudpu: Remove unused flag variable > libquorum: memset/memcpy proper size of callbacks > coroipcc: proper path size in coroipcc_zcb_alloc > totemconfig: discard check of objdb_get_string ret > mainconfig: Check retval of logsys_format_set > notifyd: Check retval of corosync_cfg_initialize > logsys: _logsys_wthread_create never returns != 0 > libcpg: Remove dead code in cpg_model_initialize > coroipcc: Test _SC_PAGESIZE result > coroparse: don't leak dirent > coroipcs: init buf in coroipcs_handler_dispatch > testcpgzc: fgets buffer to really allocated size > totemudp: memset of proper size > votequorum: free newly allocated node if nodeid==0 > cpg: do_proc_join change list_slice to list_add > crypto: rng_make_prng prevent buf overflow > crypto: handle overflow in HASH_PROCESS macro >
Thanks for the great work here. Really good effort. A few patches need a bit of changes and a couple I'd rather ignore the coverity warnings on. I responded to each individually. Regards -steve > Jerome Flesch (1): > Corosync: Fix build when done with --enable-fatal-warnings > > exec/coroipcs.c | 4 ++-- > exec/coroparse.c | 6 ++++-- > exec/coropoll.c | 8 ++++++-- > exec/crypto.c | 5 ++++- > exec/logsys.c | 2 +- > exec/main.c | 17 ++++++++++++++--- > exec/mainconfig.c | 4 +++- > exec/totemconfig.c | 7 ++++--- > exec/totemudp.c | 2 +- > exec/totemudpu.c | 1 - > exec/util.h | 1 + > lib/coroipcc.c | 10 +++++++++- > lib/cpg.c | 4 ---- > lib/quorum.c | 4 ++-- > services/cpg.c | 2 +- > services/votequorum.c | 5 +++++ > test/testcpg.c | 4 +++- > test/testcpgzc.c | 2 +- > tools/corosync-notifyd.c | 13 +++++++++++-- > tools/corosync-objctl.c | 1 - > 20 files changed, 72 insertions(+), 30 deletions(-) > > _______________________________________________ > Openais mailing list > Openais@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
