Steven Dake wrote:
> On 06/01/2011 09:14 AM, Jan Friesse wrote:
>> Signed-off-by: Jan Friesse <jfrie...@redhat.com>
>> ---
>>  tools/corosync-notifyd.c |    7 ++++++-
>>  1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c
>> index 5ac2b83..cdb6dcd 100644
>> --- a/tools/corosync-notifyd.c
>> +++ b/tools/corosync-notifyd.c
>> @@ -828,7 +828,12 @@ _cs_local_node_info_get(char **nodename, uint32_t 
>> *nodeid)
>>      corosync_cfg_handle_t cfg_handle;
>>  
>>      if (local_nodeid == 0) {
>> -            corosync_cfg_initialize(&cfg_handle, NULL);
>> +            rc = corosync_cfg_initialize(&cfg_handle, NULL);
>> +            if (rc != CS_OK) {
>> +                    syslog (LOG_ERR, "Failed to initialize the cfg API. 
>> Error %d\n", rc);
>> +                    exit (EXIT_FAILURE);
>> +            }
>> +
>>              rc = corosync_cfg_local_get (cfg_handle, &local_nodeid);
>>              corosync_cfg_finalize(cfg_handle);
>>              if (rc != CS_OK) {
> 
> ugh syslog, well good for now, but keep this in mind when we move to
> libqb that this code should be reworked to use the common logging
> infrastructure.
> 
> Reviewed-by: Steven Dake <sd...@redhat.com>

Whole notifyd should be reworked to use common logging infrastructure,
so no problem there.

_______________________________________________
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to