On Monday, 16 April 2018 at 20:20, David van der Spoel wrote: > Den 2018-04-16 kl. 17:36, skrev David Koes: > > I didn't chime in since I thought it was obviously a good idea. > > However, I strongly agree that the process of creating a test case needs > > to be as simple and documented as possible. I had a test case with my > > last pull request, but it required a fair amount of poking around to > > figure out how to best implement it (and this experience prompted the > > GSoC project). > > > > Also, test cases may not make sense for some pull requests (e.g. > > documentation). > > Agree tests are a must. > > How about making warning-free code a must?
Warning-free under which compiler (and version)? GCC adds new warnings in every release. Regards, Dominik -- Fedora https://getfedora.org | RPMFusion http://rpmfusion.org There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
