I would be in favor of making boost a default that has to be explicitly disabled with a cmake define (but still require building w/o boost to work). The failure message would tell the user what they have to pass to disable the boost requirement.
David Koes Assistant Professor Computational & Systems Biology University of Pittsburgh On Jun 11, 2019, at 11:18 AM, Patrick Lorton <klor...@gmail.com<mailto:klor...@gmail.com>> wrote: OK Geoff - sounds good, I'll change the code so that it checks for boost and only turns maeparser on if boost is present. To clarify my worries about package maintainers, it's not that they'd have a problem with turning boost on, it's just that if we don't make the default build hard fail w/o boost, they won't even investigate and think to add boost as a requirement. Maybe I'm not giving them enough credit :) Or maybe I should just pester the major package maintainers to make sure they realize after this goes in. There is one issue that remains around this that I can think of: The GitHub builders. Do we want to add boost there so they test building maestro and running the tests? Or do you run multiple builders with different settings? I'm happy to help there, but if there's someone who owns this for you, I'm also happy to just raise the flag and move on. Pat
_______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
