details: https://code.openbravo.com/erp/devel/pi/rev/28a36b5b5905
changeset: 30603:28a36b5b5905
user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
date: Thu Nov 03 19:50:33 2016 +0100
summary: Related to issue 34234: Code review improvements
diffstat:
src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
| 4 ++--
web/js/cancelAndReplace.js
| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diffs (33 lines):
diff -r 819624ec877c -r 28a36b5b5905
src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
---
a/src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
Fri Nov 04 09:08:03 2016 +0100
+++
b/src/org/openbravo/common/actionhandler/CancelAndReplaceGetCancelledOrderLine.java
Thu Nov 03 19:50:33 2016 +0100
@@ -11,7 +11,7 @@
* under the License.
* The Original Code is Openbravo ERP.
* The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2015 Openbravo SLU
+ * All portions are Copyright (C) 2016 Openbravo SLU
* All Rights Reserved.
* Contributor(s): ______________________________________.
************************************************************************
@@ -38,7 +38,7 @@
String orderLineId = "";
try {
final JSONArray jsonArray = new JSONObject(data).getJSONArray("records");
- for (int i = 0, size = jsonArray.length(); i < size; i++) {
+ for (int i = 0; i < jsonArray.length(); i++) {
JSONObject jsonOrderLine = jsonArray.getJSONObject(i);
orderLineId = jsonOrderLine.getString("replacedorderline");
OrderLine orderLine = OBDal.getInstance().get(OrderLine.class,
orderLineId);
diff -r 819624ec877c -r 28a36b5b5905 web/js/cancelAndReplace.js
--- a/web/js/cancelAndReplace.js Fri Nov 04 09:08:03 2016 +0100
+++ b/web/js/cancelAndReplace.js Thu Nov 03 19:50:33 2016 +0100
@@ -54,7 +54,7 @@
OB.CancelAndReplace.ClientSideEventHandlersPreDelete.showMessage = function
(view, form, grid, extraParameters, actions) {
var recordsToDelete = extraParameters.recordsToDelete,
- record, replacementRecords = [],
+ replacementRecords = [],
record, deliveredQuantity;
view.messageBar.keepOnAutomaticRefresh = true;
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
