details: https://code.openbravo.com/erp/devel/pi/rev/6096b50fa7d0
changeset: 30604:6096b50fa7d0
user: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
date: Fri Nov 04 11:12:25 2016 +0100
summary: Related with issue 30515: Code review improvements
diffstat:
src-core/src/org/openbravo/base/ExecutionLimitBaseProcess.java | 2 +-
src-core/src/org/openbravo/buildvalidation/BuildValidation.java | 5 ++---
src-core/src/org/openbravo/modulescript/ModuleScript.java | 2 --
3 files changed, 3 insertions(+), 6 deletions(-)
diffs (55 lines):
diff -r 28a36b5b5905 -r 6096b50fa7d0
src-core/src/org/openbravo/base/ExecutionLimitBaseProcess.java
--- a/src-core/src/org/openbravo/base/ExecutionLimitBaseProcess.java Thu Nov
03 19:50:33 2016 +0100
+++ b/src-core/src/org/openbravo/base/ExecutionLimitBaseProcess.java Fri Nov
04 11:12:25 2016 +0100
@@ -21,7 +21,7 @@
public abstract class ExecutionLimitBaseProcess {
- private static final Logger log4j =
Logger.getLogger(ExecutionLimitBaseProcess.class);
+ protected static final Logger log4j =
Logger.getLogger(ExecutionLimitBaseProcess.class);
private ConnectionProvider cp;
diff -r 28a36b5b5905 -r 6096b50fa7d0
src-core/src/org/openbravo/buildvalidation/BuildValidation.java
--- a/src-core/src/org/openbravo/buildvalidation/BuildValidation.java Thu Nov
03 19:50:33 2016 +0100
+++ b/src-core/src/org/openbravo/buildvalidation/BuildValidation.java Fri Nov
04 11:12:25 2016 +0100
@@ -14,7 +14,6 @@
import java.util.ArrayList;
import java.util.List;
-import org.apache.log4j.Logger;
import org.openbravo.base.ExecutionLimitBaseProcess;
import org.openbravo.base.ExecutionLimits;
@@ -24,10 +23,10 @@
*
*/
public abstract class BuildValidation extends ExecutionLimitBaseProcess {
- private static final Logger log4j = Logger.getLogger(BuildValidation.class);
+
private static final String BUILD_VALIDATION = "BuildValidation";
- private ArrayList<String> errors;
+ private List<String> errors;
/**
* This method must be implemented by the BuildValidations, and is used to
define the actions that
diff -r 28a36b5b5905 -r 6096b50fa7d0
src-core/src/org/openbravo/modulescript/ModuleScript.java
--- a/src-core/src/org/openbravo/modulescript/ModuleScript.java Thu Nov 03
19:50:33 2016 +0100
+++ b/src-core/src/org/openbravo/modulescript/ModuleScript.java Fri Nov 04
11:12:25 2016 +0100
@@ -11,7 +11,6 @@
*/
package org.openbravo.modulescript;
-import org.apache.log4j.Logger;
import org.apache.tools.ant.BuildException;
import org.openbravo.base.ExecutionLimitBaseProcess;
import org.openbravo.base.ExecutionLimits;
@@ -24,7 +23,6 @@
*/
public abstract class ModuleScript extends ExecutionLimitBaseProcess {
- private static final Logger log4j = Logger.getLogger(ModuleScript.class);
private static final String MODULE_SCRIPT = "ModuleScript";
/**
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
