https://bugs.freedesktop.org/show_bug.cgi?id=91966

--- Comment #59 from Kevin Brace <kevinbr...@gmx.com> ---
(In reply to Benno Schulenberg from comment #55)

Hi Benno,

> That is nearly right: instead of '-cr' you would use '-ur', making a unified
> diff.
> 

Yes, looking at the several patches, I did notice that when patches are
created, they are done against the current master branch on the Git repository
rather than using diff against the cloned version on the local computer.
I honestly do not want to create the patch against the cloned version on my
computer.


> However, it seems you make patches from an unpacked tarball.  It would be
> much better if you made your changes in git.  That is: in git branches.
> 
> Use 'git clone' to make a copy of the openchrome repository.  Then use 'git
> checkout -b somefix' to make a branch, then make your changes there, and
> when you have a self-contained small change ready, you do 'git commit -a'
> and write a nice commit summary.  Then you make more changes, and then
> commit those, and so on.  Instead of 'somefix' you use whatever name is
> appropriate for the thing you are working on.  The smaller the single,
> self-contained commits, the better.

Benno, I think I figured out how to create a patch, and I will upload it
shortly.
It doesn't really fix anything, but it merely updates a few cosmetic issues of
OpenChrome (i.e., VM800 / VN800 naming issue, better device support message in
Xorg.0.log.).

Regards,

Kevin Brace

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Openchrome-devel mailing list
Openchrome-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/openchrome-devel

Reply via email to