On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote: > Checking that all installed files are shipped is in reality a QA check. > It would benefit from mechanisms like ERROR_QA/WARNING_QA. So move it > into insane.bbclass. If some of the files are installed but should not > be shipped for some reasons, one can add them to the variable > IGNORE_UNSHIPPED_FILES. > > Signed-off-by: Dmitry Eremin-Solenikov <dbarysh...@gmail.com> > --- > meta/classes/insane.bbclass | 49 ++++++++++++++++++++++++++++++++++++++++- > meta/classes/package.bbclass | 15 ------------ > 2 files changed, 47 insertions(+), 17 deletions(-)
I like the patch and have been thinking we should do something like this. One minor comment below. > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass > index 5726e69..7a8643a 100644 > --- a/meta/classes/insane.bbclass > +++ b/meta/classes/insane.bbclass > @@ -100,7 +100,7 @@ def package_qa_get_machine_dict(): > > > # Currently not being used by default "desktop" > -WARN_QA ?= "ldflags useless-rpaths rpaths" > +WARN_QA ?= "ldflags useless-rpaths rpaths unshipped" > ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la > perms" > > def package_qa_clean_path(path,d): > @@ -485,6 +485,48 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, d): > > return sane > > +IGNORE_UNSHIPPED_FILES ??= "" > + > +def packages_qa_unshipped_files(d): > + skip = (d.getVar('INSANE_SKIP_${PN}', True) or "").split() > + if "unshipped" in skip: > + return False How about just check for unshipped in QA_WARN and QA_ERROR here and if not in either, just return? You cover handling ignoring files just below. > + seen = d.getVar('IGNORE_UNSHIPPED_FILES', True).split() > + unshipped = [] > + dvar = d.getVar('PKGD', True) > + destvar = d.getVar('PKGDEST', True) > + packages = d.getVar('PACKAGES', True).split() > + for p in packages: Cheers, Richard _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core