Hi Alex,

Yes,  The setting REQUIRED_DISTRO_FEATURES = "opengl" is in gtk4 recipe. Apart 
from that, gtk4 depends on libepoxy which also needs opengl distro.

Thanks,
________________________________
From: Alexander Kanavin <alex.kana...@gmail.com>
Sent: Friday, December 23, 2022 17:43
To: Yu, Mingli <mingli...@windriver.com>
Cc: openembedded-core@lists.openembedded.org 
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] gcr: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know 
the content is safe.
Is OpenGL really mandatory for gtk4?

Alex

On Fri 23. Dec 2022 at 10.32, Yu, Mingli 
<mingli...@eng.windriver.com<mailto:mingli...@eng.windriver.com>> wrote:
From: Mingli Yu <mingli...@windriver.com<mailto:mingli...@windriver.com>>

Fixes:
  $ bitbake gcr
  ERROR: Nothing PROVIDES 'gtk4' (but 
/build/layers/oe-core/meta/recipes-gnome/gcr/gcr_4.0.0.bb<https://urldefense.com/v3/__http://gcr_4.0.0.bb__;!!AjveYdw8EvQ!aAHHBL_XF2Kj8Qx6nJlx-VEmLcYaA6O2xpfAAnzq3_mgKI4R6JBzXRulca1gkiY5Et5Kwi6bPycXwXHb4CuXgAucUmL4$>
 DEPENDS on or otherwise requires it)
gtk4 was skipped: missing required distro feature 'opengl' (not in 
DISTRO_FEATURES)
  ERROR: Required build target 'gcr' has no buildable providers.
  Missing or unbuildable dependency chain was: ['gcr', 'gtk4']

Signed-off-by: Mingli Yu 
<mingli...@windriver.com<mailto:mingli...@windriver.com>>
---
 
meta/recipes-gnome/gcr/gcr_4.0.0.bb<https://urldefense.com/v3/__http://gcr_4.0.0.bb__;!!AjveYdw8EvQ!aAHHBL_XF2Kj8Qx6nJlx-VEmLcYaA6O2xpfAAnzq3_mgKI4R6JBzXRulca1gkiY5Et5Kwi6bPycXwXHb4CuXgAucUmL4$>
 | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/meta/recipes-gnome/gcr/gcr_4.0.0.bb<https://urldefense.com/v3/__http://gcr_4.0.0.bb__;!!AjveYdw8EvQ!aAHHBL_XF2Kj8Qx6nJlx-VEmLcYaA6O2xpfAAnzq3_mgKI4R6JBzXRulca1gkiY5Et5Kwi6bPycXwXHb4CuXgAucUmL4$>
 
b/meta/recipes-gnome/gcr/gcr_4.0.0.bb<https://urldefense.com/v3/__http://gcr_4.0.0.bb__;!!AjveYdw8EvQ!aAHHBL_XF2Kj8Qx6nJlx-VEmLcYaA6O2xpfAAnzq3_mgKI4R6JBzXRulca1gkiY5Et5Kwi6bPycXwXHb4CuXgAucUmL4$>
index 264069ffd1..22edd386fc 100644
--- 
a/meta/recipes-gnome/gcr/gcr_4.0.0.bb<https://urldefense.com/v3/__http://gcr_4.0.0.bb__;!!AjveYdw8EvQ!aAHHBL_XF2Kj8Qx6nJlx-VEmLcYaA6O2xpfAAnzq3_mgKI4R6JBzXRulca1gkiY5Et5Kwi6bPycXwXHb4CuXgAucUmL4$>
+++ 
b/meta/recipes-gnome/gcr/gcr_4.0.0.bb<https://urldefense.com/v3/__http://gcr_4.0.0.bb__;!!AjveYdw8EvQ!aAHHBL_XF2Kj8Qx6nJlx-VEmLcYaA6O2xpfAAnzq3_mgKI4R6JBzXRulca1gkiY5Et5Kwi6bPycXwXHb4CuXgAucUmL4$>
@@ -20,6 +20,8 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 inherit gnomebase gtk-icon-cache gi-docgen features_check 
upstream-version-is-even vala gobject-introspection gettext mime mime-xdg
 UPSTREAM_CHECK_REGEX = "gcr-(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)\.tar.xz"

+REQUIRED_DISTRO_FEATURES = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 
'opengl', '', d)}"
+
 SRC_URI += 
"file://0001-meson.build-correctly-handle-disabled-ssh_agent-opti.patch"
 SRC_URI[archive.sha256sum] = 
"c45855924f0ee7bab43e2dd38bfafd2ac815c6e9864341c0161e171173dcec7c"

--
2.25.1




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#175512): 
https://lists.openembedded.org/g/openembedded-core/message/175512
Mute This Topic: https://lists.openembedded.org/mt/95842308/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to