On Thu, Jan 19, 2023 at 4:57 AM Richard Purdie
<[email protected]> wrote:
>
> Hi Anuj/Bruce/Jan-Simon/Scott,
>
> Please see the links below. This patch, pending for master triggers a
> few warnings in a few layers as there are a handful of patches with no
> Upstream-Status present in them.
>
> I know this kind of thing is annoying but it is probably worth starting
> to give the wider community the hint that they should document this,
> and if they do document it, it might remind them to try and submit them
> too. You're not the target audience but as layers being tested on the
> autobuilder you get to lead by example! :)
>
> If anyone doesn't want to tweak things to fix this, we can disable the
> warnings for that specific test but I would prefer not to, I think this
> is the right thing to encourage. The numbers of issues are low and
> easily avoided one way or another.

I'd prefer the upstream-status check to be disabled for meta-virtualization.

This isn't something that I'm strictly enforcing, and not something that I
want to start strictly enforcing.

Cheers,

Bruce

>
> On Thu, 2023-01-19 at 10:24 +0100, Luca Ceresoli wrote:
> > On Wed, 18 Jan 2023 14:22:19 +0000
> > "Richard Purdie" <[email protected]> wrote:
> >
> > > Currently, whilst patch errors or warnings are shown, the errors don't 
> > > stop builds.
> > > The configuration isn't very configurable from WARN_QA and ERROR_QA 
> > > either.
> > >
> > > This patch:
> > >  * Uses the standard mechanisms to handle the patch fuzz warnings/errors
> > >  * Makes Upstream-Status checking configurable from WARN/ERROR_QA
> > >  * Allows that checking to be used with non-core layers
> > >  * Makes patch-fuzz an error by default
> > >  * Enables warnings for missing Upstream-Status in non-core layer patches 
> > > by default
> > >
> > > Signed-off-by: Richard Purdie <[email protected]>
> > > ---
> > >  meta/classes-global/insane.bbclass | 27 ++++++++++++++++++---------
> > >  1 file changed, 18 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/meta/classes-global/insane.bbclass 
> > > b/meta/classes-global/insane.bbclass
> > > index ada8a7ef4e4..e1295f85392 100644
> > > --- a/meta/classes-global/insane.bbclass
> > > +++ b/meta/classes-global/insane.bbclass
> > > @@ -29,11 +29,12 @@
> > >  WARN_QA ?= " libdir xorg-driver-abi buildpaths \
> > >              textrel incompatible-license files-invalid \
> > >              infodir build-deps src-uri-bad symlink-to-sysroot multilib \
> > > -            invalid-packageconfig host-user-contaminated uppercase-pn 
> > > patch-fuzz \
> > > +            invalid-packageconfig host-user-contaminated uppercase-pn \
> > >              mime mime-xdg unlisted-pkg-lics unhandled-features-check \
> > >              missing-update-alternatives native-last missing-ptest \
> > >              license-exists license-no-generic license-syntax 
> > > license-format \
> > >              license-incompatible license-file-missing obsolete-license \
> > > +            patch-status-noncore \
> >
> > AB testing with this patch applied revealed a few Upstream-Status
> > warnings:
> >
> > - 5 in meta-agl-core:
> >   
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/120/builds/2272/steps/13/logs/stdio
> >
> > - 3 in meta-intel:
> >   
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/100/builds/3968/steps/13/logs/stdio
> >
> > Jan-Simon, Anuj, can you look at those patches and maybe fix the 
> > Upstream-Status?
> >
> > Richard, this patch didn't trigger any problems in my test branch. Now
> > I'm going to remove it from my testing branch in order to avoid
> > warnings on issues we already know, unless you prefer me too keep it
> > and ignore the above mentioned warnings until they are fixed in the
> > respective layers.
>
> There are also some in meta-virt:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1168/steps/13/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1168/steps/21/logs/warnings
>
> Cheers,
>
> Richard
>
>
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176139): 
https://lists.openembedded.org/g/openembedded-core/message/176139
Mute This Topic: https://lists.openembedded.org/mt/96354584/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to