Since this needs to be reworked for the next libportal version anyway, maybe we could do it just like that for now?

diff --git a/meta/recipes-gnome/libportal/libportal_0.6.bb b/meta/recipes-gnome/libportal/libportal_0.6.bb
index ca58ef4138..bf38fc85fd 100644
--- a/meta/recipes-gnome/libportal/libportal_0.6.bb
+++ b/meta/recipes-gnome/libportal/libportal_0.6.bb
@@ -15,6 +15,6 @@ GIDOCGEN_MESON_OPTION = 'docs'

ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"

-DEPENDS += "glib-2.0 glib-2.0-native gtk+3 gtk4"
+DEPENDS += "glib-2.0 glib-2.0-native gtk+3 ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)}"

-EXTRA_OEMESON = "-Dbackends=gtk3,gtk4"
+EXTRA_OEMESON = "-Dbackends=gtk3${@bb.utils.contains('DISTRO_FEATURES', 'opengl', ',gtk4', '', d)}"


Am Mo, 20. Feb 2023 um 14:18:13 +0100 schrieb Markus Volk <f_...@t-online.de>:
I guess this commit will fix the issue for libportal, because we would then be able to remove the gtk+3 and gtk4 dependency as both are now optional.

<https://github.com/flatpak/libportal/commit/333a299a3c7580de3a8fbbe882ab28f5666338bd>

Am Mo, 20. Feb 2023 um 16:36:53 +0800 schrieb "Yu, Mingli" <mingli...@eng.windriver.com>:
Ping.

Thanks,

On 1/9/23 17:10, Alexander Kanavin wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

On Mon, 9 Jan 2023 at 10:02, Yu, Mingli <mingli...@windriver.com <mailto:mingli...@windriver.com>> wrote:
Sorry for noise!

Originally, the patch is used to fix the yocto compliance issue. The libportal depends on gtk4 and there is a line "REQUIRED_DISTRO_FEATURES = "opengl"" as [1] in gtk4_4.8.2.bb. If not make opengl mandatory for libportal, how to solve the below yocto compliance issue? Any hints?


ERROR: Nothing PROVIDES 'gtk4' (but
/build/layers/oe-core/meta/recipes-gnome/libportal/libportal_0.6.bb
DEPENDS on or otherwise requires it)
gtk4 was skipped: missing required distro feature 'opengl' (not in
DISTRO_FEATURES)
ERROR: Required build target 'meta-world-pkgdata' has no buildable
providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
'libportal', 'gtk4']


[1]
<https://git.openembedded.org/openembedded-core/tree/meta/recipes-gnome/gtk+/gtk4_4.8.2.bb#n55>

Thanks for clarifying. Meanwhile there was a discussion in a different
thread about this, so the patch is fine.

Alex




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177404): 
https://lists.openembedded.org/g/openembedded-core/message/177404
Mute This Topic: https://lists.openembedded.org/mt/96090762/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to