From: Alexander Kanavin <a...@linutronix.de>
Otherwise the calling code can only issue a generic, unhelpful
erorr message, and it's difficult to tell what went wrong
if logger.error output is obscured or redirected.
Signed-off-by: Alexander Kanavin <a...@linutronix.de>
---
meta/lib/bblayers/makesetup.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/meta/lib/bblayers/makesetup.py b/meta/lib/bblayers/makesetup.py
index 99d59737602..8148b0d9ff4 100644
--- a/meta/lib/bblayers/makesetup.py
+++ b/meta/lib/bblayers/makesetup.py
@@ -48,8 +48,9 @@ class MakeSetupPlugin(LayerPlugin):
if l_name == 'workspace':
continue
if l_ismodified:
- logger.error("Layer {name} in {path} has uncommitted
modifications or is not in a git repository.".format(name=l_name,path=l_path))
- return
+ e = "Layer {name} in {path} has uncommitted modifications or
is not in a git repository.".format(name=l_name,path=l_path)
+ logger.error(e)
+ raise Exception(e)
repo_path = oe.buildcfg.get_metadata_git_toplevel(l_path)
if self._is_submodule(repo_path):
@@ -63,8 +64,9 @@ class MakeSetupPlugin(LayerPlugin):
if repo_path == destdir_repo:
repos[repo_path]['contains_this_file'] = True
if not repos[repo_path]['git-remote']['remotes'] and not
repos[repo_path]['contains_this_file']:
- logger.error("Layer repository in {path} does not have any
remotes configured. Please add at least one with 'git remote
add'.".format(path=repo_path))
- return
+ e = "Layer repository in {path} does not have any remotes
configured. Please add at least one with 'git remote
add'.".format(path=repo_path)
+ logger.error(e)
+ raise Exception(e)
top_path = os.path.commonpath([os.path.dirname(r) for r in
repos.keys()])
--
2.39.2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199084):
https://lists.openembedded.org/g/openembedded-core/message/199084
Mute This Topic: https://lists.openembedded.org/mt/105958239/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
