Dear Alexander,
Firstly, let me apologize for the late reply I have been out of office.
On 8/28/25 7:51 AM, Alexander Kanavin wrote:
On Thu, 28 Aug 2025 at 00: 21, Antonios Christidis via
lists. openembedded. org
<a-christidis=ti. com@ lists. openembedded. org> wrote: >
+test_array=("testdraw2" "testgeometry" "testsprite2" "testgles2"
"testoffscreen") > + > +test_path="/usr/bin/sdl2_tests/"
ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source
of this email and know the content is safe.
Report Suspicious
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!tDdkczhAu0BQayjEE53DlJ0ytQAfSnNSsAwaZZ6yMwLiJIuXLljNpENyKyUvPwWHY4FZNPKxMRcNExZlXWUX0mmQrEBfjWJom99n7qlVvJ7-UcRwcWlWG7GV1ds$>
ZjQcmQRYFpfptBannerEnd
On Thu, 28 Aug 2025 at 00:21, Antonios Christidis via
lists.openembedded.org <[email protected]>
wrote:
> +test_array=("testdraw2" "testgeometry" "testsprite2" "testgles2"
"testoffscreen")
> +
> +test_path="/usr/bin/sdl2_tests/"
I know this somewhat contradicts what I said before, but now I think
we should just keep this simple and install these under
/usr/lib/libsdl2/ptest/tests, and package them in $PN-ptest. Putting
something executable in a sub-directory under /usr/bin is very
non-standard.
I understand your point about keeping things simple and installing the
tests under |/usr/lib/libsdl2/ptest/tests|, but I have some concerns
about merging the packages.
I believe it's beneficial to keep the |$PN-tests| and |$PN-ptest|
packages separate. The tests can run without the need for ptest tools,
and by keeping them separate, we avoid creating a needless dependency.
Merging the two, can lead to users making a false assumption that the
tests need some sort of tooling provided by ptest to run.
Moreover, having the tests in a separate package allows users to easily
include them in their filesystem without having to rebuild the entire
package with |DISTRO_FEATURES| including |ptest|. This is particularly
important since rebuilding with |ptest| enabled in my experience can
cause a significant increase in build time, as it often triggers the
rebuild of basic package dependencies.
I do agree with the placement of tests being non-standard, do you have
any suggestions on elsewhere to place them ? Aside from
|/usr/lib/libsdl2/ptest/tests| .
Also run-ptest should not hardcode the list of tests, and just run
everything in a directory.
> @@ -48,6 +50,7 @@ EXTRA_OECMAKE = "-DSDL_OSS=OFF -DSDL_ESD=OFF -DSDL_ARTS=OFF
\
> -DSDL_X11_XRANDR=OFF \
> -DSDL_X11_XSCRNSAVER=OFF \
> -DSDL_X11_XSHAPE=OFF \
> + -DSDL_TESTS=ON \
This should stay as PACKAGECONFIG, and be enabled subject to ptest in
DISTRO_FEATURES.
Looking over other packages that have ptest support, they often
automatically build tests without the need for setting PACKAGECONFIGS.
Alex
Kind Regards,
Antonios
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#222735):
https://lists.openembedded.org/g/openembedded-core/message/222735
Mute This Topic: https://lists.openembedded.org/mt/114926113/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
