On 05/03/2012 10:12 AM, Bernhard Reutner-Fischer wrote:
The error message erroneously talked about TMPDIR.
Just use OE_TMPDIR everywhere to make the name of the variable obvious.

Signed-off-by: Bernhard Reutner-Fischer<rep.dot....@gmail.com>

Bernhard,

This change wasn't well-tested and has broken the runqemu script for both bash and dash. :(

From what I can tell, the =~ regex operator is a bashism. It's also one that helps a lot with the code readability. So now that we're faced with re-writing the script to avoid using that operator, I'm having second thoughts about whether the runqemu script really needs to be shell-agnostic. The alternative of invoking grep or other commands to process the name patterns does not appeal to me.

I can understand why we're trying to ensure our build system doesn't require /bin/sh to be bash, but I think support scripts like runqemu might be a special case.

What do other people in the community think of this? The runqemu script isn't trivial, and it has to run in a lot of different contexts. Should we put the time in to make it shell-agnostic, or allow it to require bash?

Scott

--
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center

_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to