On Thu, Mar 26, 2015 at 10:33 AM, Bottazzini, Bruno <bruno.bottazz...@intel.com> wrote: > On Qui, 2015-03-26 at 09:52 +0100, Andreas Oberritter wrote: >> Hi Bruno, >> >> On 25.03.2015 22:49, Bruno Bottazzini wrote: >> > if one wants to launch a simple deamon, most modules are not >> > required. >> > He will be able to save space and exclude unwanted packages >> > from the final image. >> > --- >> > meta/recipes-core/systemd/systemd_219.bb | 1073 >> > ++++++++++++++++++++++++++---- >> > 1 file changed, 943 insertions(+), 130 deletions(-) >> > >> > diff --git a/meta/recipes-core/systemd/systemd_219.bb >> > b/meta/recipes-core/systemd/systemd_219.bb >> > index e2ea81e..9bb104f 100644 >> > --- a/meta/recipes-core/systemd/systemd_219.bb >> > +++ b/meta/recipes-core/systemd/systemd_219.bb >> > @@ -19,7 +19,7 @@ PROVIDES = "udev" >> > >> > PE = "1" >> > >> > -DEPENDS = "kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native >> > acl readline dbus libcap libcgroup glib-2.0 qemu-native util-linux" >> > +DEPENDS = "intltool-native gperf-native readline libcap libcgroup >> > qemu-native" >> > >> > SECTION = "base/shell" >> > >> > @@ -62,23 +62,45 @@ LDFLAGS_append_libc-uclibc = " -lrt" >> > >> > GTKDOC_DOCDIR = "${S}/docs/" >> > >> > -PACKAGECONFIG ??= "xz ldconfig \ >> > +PACKAGECONFIG ??= " \ >> > + gcrypt \ >> > + kmod \ >> > + ldconfig \ >> > + ${@bb.utils.contains('DISTRO_FEATURES', 'blkid', >> > 'blkid', '', d)} \ >> > + ${@bb.utils.contains('DISTRO_FEATURES', 'efi', 'efi', >> > '', d)} \ >> > + ${@bb.utils.contains('DISTRO_FEATURES', 'lz4', 'lz4', >> > '', d)} \ >> > + ${@bb.utils.contains('DISTRO_FEATURES', 'xz', 'xz', >> > '', d)} \ >> > + ${@bb.utils.contains('DISTRO_FEATURES', 'libidn', >> > 'libidn', '', d)} \ >> >> please don't invent new distro features for packageconfig of a single >> recipe. >> >> Regards, >> Andreas > > Andreas, > > Firstly, thank you a lot, for reviewing this patch > > > How would you suggest to change this code ? > > Should I do the following ? > > PACKAGECONFIG ??= " \ > gcrypt \ > kmod \ > ldconfig \ > blkid \ > efi \ > ... \ > an so on ?
Yes. Virtually all options which can be enabled/disabled should have a PACKAGECONFIG entry and you shouldn't change the features which are enabled/disabled in this commit. This can potentially be done in another next commit but will be unlikely to be ported for fido as it may impose bad surprises for users. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core