Hi Tim, Hi Armin, sorry for the late response, just came back from vacation.
On Wed, Jul 10, 2024 at 12:10:01PM GMT, Tim Orling wrote: > On Wed, Jul 10, 2024 at 8:14 AM Tim Orling <tim.orl...@konsulko.com> wrote: > > On Tue, Jul 9, 2024 at 5:54 AM Richard Leitner <d...@g0hl1n.net> wrote: > > > >> Hi Armin, > >> > >> On Tue, Jul 09, 2024 at 08:12:06AM GMT, akuster808 wrote: > >> > Hello Richard, > >> > > >> > On 7/6/24 2:08 PM, Richard Leitner via lists.openembedded.org wrote: > >> > > The currently available python-3-pydantic v2.7.0 requires > >> > > python3-pydantic-core to be updated to v2.18.1. > >> > > > I don't know what we want to do with scarthgap. Part of me thinks we should > revert the 2.7.0 upgrade to one which is compatible with 2.16.3 > python3-pydantc-core. Part of me thinks upgrade python3-pydantic-core to > 2.18.1, but we won't have that in master. Right now, it appears to me that > we need new recipes (python3-tzdata) in order to build 2.19.0 (I did not > look at 2.18.x). Adding new recipes sounds against stable policy to me. Tbh it wasn't clear to me why the pydantic (not -core) update to 2.7.0 was accepted at all (for scarthgap) as it bumps the minor version. Is this sane/desired? ... Even after reading "Stable/LTS Patch Acceptance Policies" by YP [1] this isn't completely clear to me (does OE have a own policy on this?. For the update (2.16.3 to 2.18.1) there isn't anythin in the pyproject.toml diff which results in dependency changes. So IMHO this should be safe. Nonetheless applying this patch to scarthgap definitely breaks the "backport only"/"master first" principle. So maybe downgrading is the "policy friendly" approach? > > > > I don't see the updated or later version in master? Am I missing > >> something? > >> > >> I found a series from Tim [1] which updates python3-pydantic and > >> python3-pydantic-core > >> to 2.7.4/1.9.0 for master. > >> As those are newer versions I didn't send this patch for master. > >> > > > > That series needed to be rebased, per khem. Just because it is on > > patchwork does not imply merging or correctness. > > During the rebase I discovered missing dependencies. Thanks for the clarification. Next time I will follow up the already existing series first. > > > > Also, python3-pydantic-core has a QA warning about TMPDIR > > WARNING: python3-pydantic-core-2.19.0-r0 do_package_qa: QA Issue: File > > /usr/lib/python3.12/site-packages/pydantic_core/_ > > pydantic_core.cpython-312-x86_64-linux-gnu.so in package > > python3-pydantic-core contains reference to TMPDIR [buildpaths] > > > > Which seems to be RUSTFLAGS being injected into the .so for some reason > > (where 14 is the .rodata section): > > readelf -p 14 pydantic_core/_pydantic_core.cpython-312-x86_64-linux-gnu.so > > > > <snip> > > [ f7c] i > > ...skipping... > > > > model-fieldsdataclasstuplefrozensetdefinition-refdefinitionsUnknown schema > > type: "2.19.0a-alphab-beta__version__profile=release pgo= -L > > /srv/build/ttorling/workspace-upgrades/build/tmp/work/core2-64-poky-linux/python3-pydantic-coas > > [ 2ae09] kwargs > > [ 2ae10] (args, > > kwargs=None)ArgsKwargs(kwargssrc/argument_markers.rsCreating instances of > > "UndefinedType" is not supportednew()\n > > <snip> > > > > The above seems to be a backtrace from the schema generation script, but I > > haven't figured out yet how to troubleshoot further. > > > > Filed an issue upstream: > https://github.com/pydantic/pydantic-core/issues/1365 > > > > > Meanwhile, upstream has updated again. > > My working branch: > > > > https://git.openembedded.org/meta-openembedded-contrib/log/?h=timo/python3-pydantic-upgrade > > > > Found more ptest RDEPENDS missing for python3-pydantic. That branch > currently passes ptests for: > bitbake (-c testimage) meta-python-image-ptest-python3-pydantic-core > bitbake (-c testimage) meta-python-image-ptest-python3-pydantic > Do you got failing ptests for scarthgap (with this patch applied) too? Or did you just tested master? [1] https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS Thanks & regards;rl
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#111399): https://lists.openembedded.org/g/openembedded-devel/message/111399 Mute This Topic: https://lists.openembedded.org/mt/107073841/21656 Group Owner: openembedded-devel+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
