I have updated branch https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls according to the technical recommendations.
Regards, Luc -----Original Message----- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexandre Fayolle - camptocamp Sent: donderdag 24 oktober 2013 10:13 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report Review: Needs Fixing code review, no test Could you take the time to bring this to the 7.0 community addons coding conventions. This includes: * not using the shortcut imports (things in the openerp namespace need to be imported from openerp) * using the from . import xxx for relative imports (typically in __init__.py files) * using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory * not instanciating the model classes * following PEP8 for spacing, line wrapping, etc. Nice to have would be a couple of automated tests exercising the code. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
