-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Antonio Ospite wrote:
> Daniel Ribeiro proposed to move GPIO definitions to ezx-<phone>.c, what
> about factoring out the common definitions in a ezx-common.h and let
> the different parts go into ezx-<phone>.h ?
>
> Do you have any more thought about this issue?
I believe that all gpio configuration should be done on the machine
file, and drivers should have no hardcoded gpio assignments.
I think that we should NOT configure GPIOs by using a common name and
changing its assigned value on a header file (like motorola did, with
#ifdefs), or, if i get what you mean, use common names and different
header files.
I agree with something like GPIOxx_<phone>_<what> as it enforces that
no drivers will rely on hardcoded gpio configuration (unless the driver
is specific to a single phone)
Most drivers already get their gpio configuration from a
platform_device, PCAP(and childs) is ok, BP handshake is just a matter
of moving the platform_device out of ezx.c. EMU will need some (a lot)
work, but i think that this is not the case with A910 (no EMU?).
And.. Are the new machine ids assigned?? If they are, we could start
thinking into merging all the phone.c files back on ezx.c and use the
machine_is_* macros to switch configuration at runtime (thats why it is
so important that all drivers get GPIO configuration from a
platform_device), and use a single kernel on all models.
- --
Daniel Ribeiro
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHmRnGw3OYl0G0liQRAga0AKCBEQ0nFNJlzgSuBjtHG0YZIxS6ZwCgha68
YzCaDiEZ0WQr3mCthOBKvzg=
=dC8X
-----END PGP SIGNATURE-----
