On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote: > + tristate "Generic rfkill regulator driver" > + depends on RFKILL || !RFKILL
That looks *odd*. Otherwise this looks fine from a regulator API point of view. You use an exclusive get() so you could get away without remembering the enable state as nothing else could hold the device open but there's no harm in doing so and it's defensive against silly constraints that force the regulator on.
