Hi Michal, Is this merge will cause any problem other than the confusion? Since OF project is already in freeze, can the bigger change be done in next release while this change will be commited as is?
Shlomi -----Original Message----- From: Michal Polkoráb [mailto:[email protected]] Sent: Tuesday, July 26, 2016 4:39 PM To: Alfasi, Shlomi <[email protected]>; [email protected]; [email protected] Cc: A H <[email protected]> Subject: Re: Adding TCP Flag Action and Match Support In Openflowjava Hello, from comments in openflowjava change: "We have followed Open Vswitch 1.5 specification document" - Openflowjava follows Openflow 1.3.5 specification. There is no such mention of tcp flag action in OF 1.3.5 specification, so these changes should be located in separate module, which would register these (de)serializers into openflowjava. Such module would be probably appreciated by more developers, as there is / was more changes of such type (as OVS has its own specification). Merging openflowjava change would cause confusion in the future. Regards, Michal ________________________________________ From: Alfasi, Shlomi <[email protected]> Sent: 26 July 2016 14:20 To: [email protected]; [email protected] Cc: Michal Polkoráb; A H Subject: Adding TCP Flag Action and Match Support In Openflowjava Hi All, The following patches were developed on top of stable/Beryllium and wasn't merged yet. Are they going to be merged to Boron also? I need them in order to implement stateless security group in the netvirt project. [1] https://git.opendaylight.org/gerrit/#/c/42389/ [2] https://git.opendaylight.org/gerrit/42388 Shlomi -----Original Message----- From: Gerrit Code Review [mailto:[email protected]] Sent: Tuesday, July 26, 2016 8:32 AM Cc: Michal Polkorab <[email protected]>; Alfasi, Shlomi <[email protected]>; A H <[email protected]>; jenkins-releng <[email protected]> Subject: Change in openflowjava[stable/beryllium]: <WIP> Adding TCP Flag Action and Match Support In Openflowjava From Bharathi M <[email protected]>: Bharathi M has posted comments on this change. Change subject: <WIP> Adding TCP Flag Action and Match Support In Openflowjava ...................................................................... Patch Set 4: > do you have any reference document for this change ? > We have followed Open Vswitch 1.5 specification document and the below two > git files as additional reference, i) https://git.opendaylight.org/gerrit/#/c/8986/ ii) https://git.opendaylight.org/gerrit/#/c/9004/ If any changes missing kindly let us know we will add it. -- To view, visit https://git.opendaylight.org/gerrit/42388 To unsubscribe, visit https://git.opendaylight.org/gerrit/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88a8b7adab8efa9fa3bdd37365a6e0aae96772c1 Gerrit-PatchSet: 4 Gerrit-Project: openflowjava Gerrit-Branch: stable/beryllium Gerrit-Owner: Bharathi M <[email protected]> Gerrit-Reviewer: A H <[email protected]> Gerrit-Reviewer: Bharathi M <[email protected]> Gerrit-Reviewer: Michal Polkorab <[email protected]> Gerrit-Reviewer: Shlomi Alfasi <[email protected]> Gerrit-Reviewer: jenkins-releng <[email protected]> Gerrit-HasComments: No MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / [email protected] reception: +421 2 206 65 114 / www.pantheon.sk [logo] _______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
