Hi Michal, Can you please review the openflowjava patch, so that we can merge openflowplugin patch before M5.
Thanks Anil On Wed, Jul 27, 2016 at 4:53 AM, Anil Vishnoi <[email protected]> wrote: > Hi Michal, > > I implemented this extension and pushed the patch to both openflowjava and > openflowplugin project. Following are the patches > > https://git.opendaylight.org/gerrit/#/q/topic:onf-ext-109-tcp-flags > > We need to first merge the openflowjava patch and then openflowplugin, so > till openflowjava plugin is not merge, openflowplugin verify will fail. > > I tested this experimenter match with OVS switch and it was working fine > (flow installation as well as statistic collection). > > Please review the patch, once you are done with review, we need to sync up > to merge the patches. > > Thanks > Anil > > On Wed, Jul 27, 2016 at 4:25 AM, Anil Vishnoi <[email protected]> > wrote: > >> Hi Michal, >> >> Here is the TCP_FLAGS extension document. I will send you the remaining >> sometime tomorrow. >> >> Thanks >> Anil >> >> On Wed, Jul 27, 2016 at 4:17 AM, Michal Polkoráb < >> [email protected]> wrote: >> >>> Hi Anil, >>> >>> >>> I can't access the link you sent me (can't even register there) and I >>> haven't found any info relevant enough on this topic. Could you please >>> attach the document in this mailing thread (possibly a document with all >>> extensions) ? >>> >>> >>> Michal >>> ------------------------------ >>> *From:* Anil Vishnoi <[email protected]> >>> *Sent:* 26 July 2016 21:25 >>> *To:* Michal Polkoráb >>> *Cc:* Alfasi, Shlomi; [email protected]; >>> [email protected]; A H >>> *Subject:* Re: [openflowplugin-dev] Adding TCP Flag Action and Match >>> Support In Openflowjava >>> >>> Hi Michal, >>> >>> There are two version of tcp_flags that is present (1) Nicira Extension >>> (2) OpenFlow Approved Extension >>> >>> 1st should be implemented as you mention above, but (2) should be part >>> of the openflow java models (as an experimenter match). Following is the >>> link of approved extension document >>> >>> >>> https://rs.opennetworking.org/wiki/download/attachments/89292834/openflow-switch-extension-ext109.pdf?version=2&modificationDate=1416877745000&api=v2 >>> >>> I believe OVS 2.5 supports (2), but older version of OVS support (1). >>> >>> I am working on (2) and will push the patch for your review by EOD. >>> >>> On Tue, Jul 26, 2016 at 6:39 AM, Michal Polkoráb < >>> [email protected]> wrote: >>> >>>> Hello, >>>> >>>> from comments in openflowjava change: "We have followed Open Vswitch >>>> 1.5 specification document" - Openflowjava follows Openflow 1.3.5 >>>> specification. There is no such mention of tcp flag action in OF 1.3.5 >>>> specification, so these changes should be located in separate module, which >>>> would register these (de)serializers into openflowjava. >>>> >>>> Such module would be probably appreciated by more developers, as there >>>> is / was more changes of such type (as OVS has its own specification). >>>> Merging openflowjava change would cause confusion in the future. >>>> >>>> Regards, >>>> Michal >>>> ________________________________________ >>>> From: Alfasi, Shlomi <[email protected]> >>>> Sent: 26 July 2016 14:20 >>>> To: [email protected]; [email protected] >>>> Cc: Michal Polkoráb; A H >>>> Subject: Adding TCP Flag Action and Match Support In Openflowjava >>>> >>>> Hi All, >>>> >>>> The following patches were developed on top of stable/Beryllium and >>>> wasn't merged yet. >>>> Are they going to be merged to Boron also? >>>> I need them in order to implement stateless security group in the >>>> netvirt project. >>>> >>>> [1] https://git.opendaylight.org/gerrit/#/c/42389/ >>>> [2] https://git.opendaylight.org/gerrit/42388 >>>> >>>> Shlomi >>>> >>>> -----Original Message----- >>>> From: Gerrit Code Review [mailto:[email protected]] >>>> Sent: Tuesday, July 26, 2016 8:32 AM >>>> Cc: Michal Polkorab <[email protected]>; Alfasi, Shlomi < >>>> [email protected]>; A H <[email protected]>; jenkins-releng < >>>> [email protected]> >>>> Subject: Change in openflowjava[stable/beryllium]: <WIP> Adding TCP >>>> Flag Action and Match Support In Openflowjava >>>> >>>> From Bharathi M <[email protected]>: >>>> >>>> Bharathi M has posted comments on this change. >>>> >>>> Change subject: <WIP> Adding TCP Flag Action and Match Support In >>>> Openflowjava >>>> ...................................................................... >>>> >>>> >>>> Patch Set 4: >>>> >>>> > do you have any reference document for this change ? >>>> >>>> > We have followed Open Vswitch 1.5 specification document and the >>>> below two git files as additional reference, >>>> i) https://git.opendaylight.org/gerrit/#/c/8986/ >>>> ii) https://git.opendaylight.org/gerrit/#/c/9004/ >>>> If any changes missing kindly let us know we will add it. >>>> >>>> -- >>>> To view, visit https://git.opendaylight.org/gerrit/42388 >>>> To unsubscribe, visit https://git.opendaylight.org/gerrit/settings >>>> >>>> Gerrit-MessageType: comment >>>> Gerrit-Change-Id: I88a8b7adab8efa9fa3bdd37365a6e0aae96772c1 >>>> Gerrit-PatchSet: 4 >>>> Gerrit-Project: openflowjava >>>> Gerrit-Branch: stable/beryllium >>>> Gerrit-Owner: Bharathi M <[email protected]> >>>> Gerrit-Reviewer: A H <[email protected]> >>>> Gerrit-Reviewer: Bharathi M <[email protected]> >>>> Gerrit-Reviewer: Michal Polkorab <[email protected]> >>>> Gerrit-Reviewer: Shlomi Alfasi <[email protected]> >>>> Gerrit-Reviewer: jenkins-releng <[email protected]> >>>> Gerrit-HasComments: No >>>> MichalPolkoráb >>>> Software Engineer >>>> >>>> Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia >>>> R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia >>>> +421 918 378 907 / [email protected] >>>> reception: +421 2 206 65 114 / www.pantheon.sk >>>> >>>> [logo] >>>> >>>> >>>> _______________________________________________ >>>> openflowplugin-dev mailing list >>>> [email protected] >>>> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >>>> >>> >>> >>> >>> -- >>> Thanks >>> Anil >>> >>> MichalPolkoráb >>> >>> Software Engineer >>> >>> >>> Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia >>> R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia >>> +421 918 378 907 / [email protected] >>> reception: +421 2 206 65 114 / www.pantheon.sk >>> >>> [image: logo] >>> >>> >>> >> >> >> >> -- >> Thanks >> Anil >> > > > > -- > Thanks > Anil > -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
