On Mon, Jul 9, 2018 at 8:30 AM, D Arunprakash <d.arunprak...@ericsson.com> wrote:
> Sam, > > I have seen this issue as well in downstream, while debugging it we have > found out the codec registered for NshNp fields were wrong in the code. > > > > Raised a review [1] for the same, but later found out it was already fixed > by Jaime’s review [2] as part of new NSH implementation. > > Let us know if it’s needed urgently, so we can merge the path [1]. > > > [2] is a big change and I don't see any review comments on it yet. It will likely take quite some time to be merged. So I'd prefer [1] to go in as it is fixing a bug than waiting for [2] which brings a new feature. [1] https://git.opendaylight.org/gerrit/#/c/73735/ > > [2] https://git.opendaylight.org/gerrit/#/c/72320/. > > > > Regards, > > Arun > > > > *From:* netvirt-dev-boun...@lists.opendaylight.org [mailto: > netvirt-dev-boun...@lists.opendaylight.org] *On Behalf Of *Sam Hague > *Sent:* Monday, July 09, 2018 8:15 AM > *To:* Anil Vishnoi <vishnoia...@gmail.com> > *Cc:* odl netvirt dev <netvirt-...@lists.opendaylight.org>; Luis Gomez < > ece...@gmail.com>; openflowplugin-dev <openflowplugin-dev@lists. > opendaylight.org>; Jamo Luhrsen <jluhr...@redhat.com> > *Subject:* Re: [netvirt-dev] ovs 2.8.2 does not work well in csit > > > > > > On Sun, Jul 8, 2018 at 5:05 PM Anil Vishnoi <vishnoia...@gmail.com> wrote: > > I believe upstream openflowplugin CSIT uses 2.8.0/1 version and that did > not contain the new NSH support and that's working fine. Seems like the new > NSH support is causing this issue. Looking like in your CSIT someone is > trying to install the flow with the NSH match or your switch has NSH based > flow. MatchConvertor comes into play when either you are pushing flow down > to the switch or reading and deserializing the stats/packet_in coming from > switch. > > > > Anil, the exception is coming from packet_in messages and not a flow being > installed. The features for sfc/nsh are not installed so pretty sure > nothing is trying to use nsh. Can you look again at the two exceptions to > see if that is correct? OVS 2.8.0 added userspace NSH support, with more > support added in 2.8.1 and 2.8.2. I see the ofp csit is using 2.8.1. it has > deserialization errors but not the same as the netvirt csit. ovs 2.8.2 says > it moved the NSH support to the standard spec support so maybe that is why > it is causing more problems that 2.8.1? > > We already have patches pushed by Jamie to implement these new NSH fields > and remove the old one, hopefully that should fix it. > > How far along are these patches? > > > > On Sun, Jul 8, 2018 at 5:26 AM Sam Hague <sha...@redhat.com> wrote: > > Adding Daya to see if they have been doing any testing with ovs 2.8.2 or > later. Also forgot netvirt-dev and openflowplugin-dev lists. > > > > On Sat, Jul 7, 2018 at 5:05 PM Sam Hague <sha...@redhat.com> wrote: > > Jamo, > > > > did we ever have any runs using ovs 2.8.2 - or really anything later than > 2.7.2? [1] is a job using ovs 2.8.2 and it fails a few tests because of an > openflow deserialization error with some NSH packets - but this is just our > normal csit and not anything related to sfc. My 2.9 jobs also had some > failures but I didn't inspect them before the sandbox cleared up this > weekend. > > > > NSH support was added in 2.8 so that makes sense this could cause a > problem. The exception below is coming out when the test fails - a ping > fails, so I guess an arp or other punt packet is being mapped to nsh and > not being decoded by openflowplugin. > > > > Jaime, Venkat, > > > > have you seen issues like this? Is it because openflowplugin has not been > updated to use the new nsh and maybe some older nsh support is causing > problems? > > > > Thanks, Sam > > > > [1] https://jenkins.opendaylight.org/sandbox/job/ > shague-queens-netvirt-csit-1node-openstack-queens- > upstream-stateful-fluorine/3/ > > > > 2018-07-07T15:28:56,461 | WARN | epollEventLoopGroup-9-1 | > MatchExtensionHelper | 364 - org.opendaylight.openflowplugin - > 0.7.0.SNAPSHOT | Convertor for > MatchEntry{_matchEntryValue=NshNpCaseValue{_nshNpValues=NshNpValues{_value=41, > augmentation=[]}, augmentation=[]}, _oxmClass=interface > org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev150225.Nxm1Class, > _oxmMatchField=interface > org.opendaylight.yang.gen.v1.urn.opendaylight.openflowjava.nx.match.rev140421.NxmNxNshNp, > _hasMask=false, augmentation=[]} for version 4 with match path > PACKET_IN_MESSAGE_MATCH not found. > > 2018-07-07T15:28:56,462 | WARN | epollEventLoopGroup-9-1 | OFDecoder > | 386 - > org.opendaylight.openflowplugin.openflowjava.openflow-protocol-impl - > 0.7.0.SNAPSHOT | Message deserialization > failedjava.lang.NullPointerException: null at > org.opendaylight.openflowplugin.openflow.md.core.extension.MatchExtensionHelper.injectExtension(MatchExtensionHelper.java:83) > [364:org.opendaylight.openflowplugin:0.7.0.SNAPSHOT] at > org.opendaylight.openflowplugin.impl.protocol.deserialization.match.MatchDeserializer.deserializeEntry(MatchDeserializer.java:104) > > > > _______________________________________________ > netvirt-dev mailing list > netvirt-...@lists.opendaylight.org > https://lists.opendaylight.org/mailman/listinfo/netvirt-dev > > > > > -- > > Thanks > > Anil > > > _______________________________________________ > openflowplugin-dev mailing list > openflowplugin-dev@lists.opendaylight.org > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > >
_______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
