http://defect.opensolaris.org/bz/show_bug.cgi?id=19105

Jens Elkner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |.de

--- Comment #4 from Jens Elkner <[email protected]> 2011-12-14 
01:07:37 UTC ---
(In reply to comment #0)
> When comparing OpenGrok file display on Solaris 11 (Firefox 6.0.3) in 0.10 and
> 0.11 it seems to me that 0.11 visual appearance has worsened.
> 
> This is with 100% magnification (Ctrl-0).
> 
> In particular:
>   - the font used for file listing is too big

Yes, now the user's font settings in the browser are honored. The dense (DPIs)
of the viewing device has an impact as well. On Solaris - if you use Gnome -
check, whether the System | Preferences | Appearance | Fonts -> Details |
Resolution matches the one you get from xdpyinfo for your screen. If not, you
have "font-zooming" in action ;-)

In Firefox use Edit | Preferences | Content | Fonts & Colors -> Advanced
Here you can set the default font size in pixels. E.g. I use
Proportional: Serif 15
Serif: Liberation Sans
Sans-serif: Liberation Serif
Monospace: Liberation Mono 14
Minimum font size: None 

However, really depends on taste and device.

>   - the font used for README file is too small

Per default it should be the same size, i.e. what you told your browser to use.
Unfortunately without access to your site it is impossible to check ...

>   - white line dividing lines of file is gone

Well, I'm pretty emotionless wrt. this. The users I asked said, it looks
smoother/better now - but this was only a hand full, so definitely not    
representative ...

Can be fixed as follows:

--- style.css.orig    Wed Dec 14 01:56:58 2011
+++ style.css    Wed Dec 14 01:59:25 2011
@@ -445,15 +445,15 @@
 #src .l, #src .hl, .blame .r, .blame .a,
 #results .l, #more .l,
 #difftable i, del.d { /* line number/annotation block */
     display: inline-block;
     width: 5ex;
     text-align: right;
     padding-right: 1ex;
-    margin-right: 0.2em;
+    margin: 0 0.2em 2px 0;
     background-color: #dddddd;
     color: #666;
 }

 #src .hl { /* highlighted line number */
     color: #000;
 }


>   - the 'Up to higher level directory' link is unaligned, surrounded by too
> much space

Not sure, what "unaligned" means in this context. The main reason for really
separating it from the table is to make it prominent, and users are able to
catch it. Another one is to make it a little bit separate from navigation bar,
so that one is able to better navigate on the page with his eyes (it not just
getting a bunch of links and text, where one needs some time, to pick up, what
he needs ...). Anyway, adjusting it as you like should be easy: Just insert the
following in the style.css and play around.

#content > p {
 margin: 0.5ex 0 0.5ex 0; /* top right bottom left */
}

When we've found, what most people like, we can add it as default?

PS: Thanx for the screenshots - helped a lot to understand, what you mean :)

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev

Reply via email to