Oh yes ... and I love what you did to the default theme, looks much
better now :)
--
L
On 6.5.2011 21:26, Lubos Kosco wrote:
Great work Jens!
I am actually very very happy someone started the cleanup of jsps
and I am looking forward to the monster patch ;)
just regarding code reviews - if you can split it into phases it would
be cool, if not I guess we can try to review it, ev. accept it and fix
whatever regression might have slipped in afterwards ... Trond, Knut,
got better ideas on such huge patches ?
cheers
L
On 6.5.2011 20:52, Jens Elkner wrote:
On Fri, May 06, 2011 at 08:08:46PM +0200, Trond Norbye wrote:
On 6. mai 2011, at 19.58, Jens Elkner wrote:
On Fri, May 06, 2011 at 06:27:28PM +0200, Trond Norbye wrote:
WOuld that approach allow you to filter out some of the items in
the "list" of available projects to search? Like if we add this
config to src.opensolaris.org/source only the logged in people
with access to OpenGrok may select opengrok there, and the rest of
the users may see all of the other projects? If so I'm happy to
back out the changeset :)
Yes, if you use a filter ;-):
http://download.oracle.com/javaee/5/api/javax/servlet/Filter.html
Yeah. that seems to do the trick..
And is probably better, since it gets control BEFORE opengrok is doing
anything [wrong] ... ;-)
BTW: Basically I probably wouldn't care about a _displayed_ projects
list. In a Filter I would simply remove inappropriate projects from
the REQUEST params/check the xref path ... ;-)
The only question is if that's good enough for the people who
requested it.
Can't speak for them, but I guess, things like
http://src.iws.cs.ovgu.de/source/xref/opengrok/src/org/opensolaris/opengrok/web/PageConfig.java
make their life a lot easier ;-)
Regards,
jel.
PS: Preparing the XHTML-wellformed/source cleanup "monster" patch
right now.
If you want, you may snoop around using the URL above...
_______________________________________________
opengrok-discuss mailing list
opengrok-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opengrok-discuss
