Roger Mach wrote:
> I took a look at these patchsets and they appear to be good, with just a
> couple of minor issues.  
Thanks for taking time to look at this.
> First, I encountered a compiler error when
> building ipmi_kcs_intf.c that I believe was already reported on the
> ipmitool-devel list earlier today by Jarrod Johnson; the extra parameter
> to ipmi_register_smi() that needs to be added to a header file.
>   
I'd actually prefer to just pull this file out.  It is a subset of what
is in ipmi_si.c and it doesn't have all the fixes and new features that
ipmi_si.c has.  Is there a problem with just removing this?
> The second issue is a simple one-line patch that fixes an off-by-one bug
> that causes the driver to not detect the BMC on any machine that has its
> BMC as the last entry in the DMI table.  This patch is not present in
> these patchsets:
>   
Ok, got it.  Thanks.

-Corey

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to