Bela Lubkin wrote: > Andrew Morton wrote: > >>> Sometime, please go through the IPMI code looking for all these >>> statically-allocated things which are initialised to 0 or NULL and remove >>> all those intialisations? They're unneeded, they increase the vmlinux >>> image size and there are quite a number of them. Thanks. > > Randy Dunlop replied: > >> I was just about to send that patch. Here it is, >> on top of the series-of-12. > ... >> -static int bt_debug = BT_DEBUG_OFF; >> +static int bt_debug; > > Is it wise to significantly degrade code readability to work around a minor > compiler / linker bug?
Is that the only one that is a problem? I don't think it's a problem. We *know* that static data areas are init to 0. Everything depends on that. If that didn't work it would all break. I could say that it's a nice coincidence that BT_DEBUG_OFF == 0, but I think that it's more than coincidence. -- ~Randy ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
