Hi, On 08-20 10:31, Corey Minyard wrote: > > > > > > > > > > > 3) It appears the response to the GET_DEVICE_ID command, though a > > > > response is returned, is not valid. The right way to handle this would > > > > be to do more validation in the ssif_detect() function. It doesn't do > > > > any validation of the response data, and that's really what needs to be > > > > done. > > > > > > > > > > do_cmd() in ssif_detect() already do validation. Perhaps, > > > ssif_probe() should just not return ENODEV in case of error. > > > > > > > Oh, I wanted to say ssif_detect, not ssif_probe. > > Yeah, that's probably the right solution. I'll look at this a bit. > But I see the problem. Do you want to do a patch, or do you want me > to?
If you want to do it, please go ahead. I don't mind. Thanks, Ivan _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer
