On Wed, Nov 05, 2025 at 07:54:49PM +0700, Bagas Sanjaya wrote: > Steps for loading IPMB driver at boot time, written as enumerated > sublist, is indented instead on the same level as its parent list. > Indent them as appropriate.
I'd like to get the review of the original author, now on the CC list. -corey > > Signed-off-by: Bagas Sanjaya <[email protected]> > --- > Documentation/driver-api/ipmb.rst | 48 +++++++++++++++---------------- > 1 file changed, 24 insertions(+), 24 deletions(-) > > diff --git a/Documentation/driver-api/ipmb.rst > b/Documentation/driver-api/ipmb.rst > index 209c49e051163f..dd99d034272b7e 100644 > --- a/Documentation/driver-api/ipmb.rst > +++ b/Documentation/driver-api/ipmb.rst > @@ -48,35 +48,35 @@ CONFIG_IPMB_DEVICE_INTERFACE=y > > 1) If you want the driver to be loaded at boot time: > > -a) Add this entry to your ACPI table, under the appropriate SMBus:: > + a) Add this entry to your ACPI table, under the appropriate SMBus:: > > - Device (SMB0) // Example SMBus host controller > - { > - Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID > - Name (_UID, 0) // Unique ID of particular host controller > - : > - : > - Device (IPMB) > - { > - Name (_HID, "IPMB0001") // IPMB device interface > - Name (_UID, 0) // Unique device identifier > - } > - } > + Device (SMB0) // Example SMBus host controller > + { > + Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID > + Name (_UID, 0) // Unique ID of particular host controller > + : > + : > + Device (IPMB) > + { > + Name (_HID, "IPMB0001") // IPMB device interface > + Name (_UID, 0) // Unique device identifier > + } > + } > > -b) Example for device tree:: > + b) Example for device tree:: > > - &i2c2 { > - status = "okay"; > + &i2c2 { > + status = "okay"; > > - ipmb@10 { > - compatible = "ipmb-dev"; > - reg = <0x10>; > - i2c-protocol; > - }; > - }; > + ipmb@10 { > + compatible = "ipmb-dev"; > + reg = <0x10>; > + i2c-protocol; > + }; > + }; > > -If xmit of data to be done using raw i2c block vs smbus > -then "i2c-protocol" needs to be defined as above. > + If xmit of data to be done using raw i2c block vs smbus > + then "i2c-protocol" needs to be defined as above. > > 2) Manually from Linux:: > > > base-commit: 27600b51fbc8b9a4eba18c8d88d7edb146605f3f > -- > An old man doll... just what I always wanted! - Clara > _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
