On Wed, 2026-07-22 at 15:11 +0000, Grégoire Layet wrote: > Add pcie_kcs4 node to the LPC bus in the ast2600 g6 common dtsi. > > The ASPEED AST2600 has a PCIe to LPC controller. It includes a KCS > interface on channel 4. This is a fully KCS-compatible interface > that is exposed over PCIe. > > This can be used by the host for IPMI when the PCIe BMC Device is > activated. > > While the datasheet provides interrupt numbers for KCS channels 1, 2, > 3 and 4 over PCI, not all 4 are described in the "PCIe to LPC Controller" > section. Since only the KCS channel 4 is described, only this channel is > added. > > The pcie_kcs4 uses existing "aspeed,ast2600-kcs-bmc" compatible as it's a > standard KCS interface. > > Signed-off-by: Grégoire Layet <[email protected]> > --- > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > index 56bb3b0444f7..a93fa4cf5d8f 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > @@ -617,6 +617,13 @@ kcs4: kcs@114 { > status = "disabled"; > }; > > + pcie_kcs4: kcs@914 {
Nodes need to be ordered by ascending address: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes Note that we now have scripts/dtc/dt-check-style which can help catch such issues. Andrew _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
