On Wed, 2026-07-22 at 15:11 +0000, Grégoire Layet wrote: > Created a 5th KCS channel to match against the KCS 4 over PCIe addresses. > > The ASPEED AST2600 has a PCIe to LPC controller. It includes a KCS > interface on channel 4. This is a fully KCS-compatible interface > that is exposed over PCIe. > > The 5th channel created is only valid on the AST2600. > This cannot be used for AST2400 and AST2500 chips, as they don't have LPC > over PCIE. > > Signed-off-by: Grégoire Layet <[email protected]> >
... > @@ -373,6 +395,9 @@ static void aspeed_kcs_enable_channel(struct > kcs_bmc_device *kcs_bmc, bool enabl > case 4: > regmap_update_bits(priv->map, LPC_HICRB, LPC_HICRB_LPC4E, > enable * LPC_HICRB_LPC4E); > return; > + case 5: > + regmap_update_bits(priv->map, PCIE_LPC_HICRB, LPC_HICRB_LPC4E, > enable * LPC_HICRB_LPC4E); This one exceeds 100 chars. checkpatch can help catch these types of issues. Otherwise this seems okay. Andrew _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
