Ok, thanks. -DrD-
> The owner of the code area (Kirill) should at least be aware of what you are > doing. > > As long you have one reviewer in the area you touched (Alexander reviewed), > then it is OK, although I want to review non-trivial build changes (which > this one isn't, but your subsequent changes will be). Anyway, I just reviewed > it. > > I will follow-up with an e-mail reminder about the additional rules for next > week since we are ramping down for milestone M1. > > -- Kevin > > > David DeHaven wrote: >> Ping Kevin, Kirill? (how many reviewers do I need these days?) >> >> -DrD- >> >> >> >>> JIRA Issue: >>> >>> https://javafx-jira.kenai.com/browse/RT-38074 >>> >>> >>> Latest webrev: >>> >>> http://cr.openjdk.java.net/~ddehaven/RT-38074/rt.2/ >>> >>> >>> Removed new makefile (eyesore), cleaned up/enhanced existing Makefile, >>> fixed a compiler warning. >>> >>> Last iteration hopefully, I let it bake for 12 hours and haven't had the >>> urge to change anything ;) >>> >>> -DrD- >>> >>> >>> >>>> Kirill, Alexander, Kevin: >>>> >>>> New version up for review, please take a look: >>>> >>>> http://cr.openjdk.java.net/~ddehaven/RT-38074/rt.1/ >>>> >>>> >>>> I moved OSXPlatform and OSXMediaPlayer code back to jfxmedia, since it was >>>> meant to be an abstraction point for using either QTKit or AVFoundation in >>>> the first place. >>>> >>>> -DrD- >>>> >>>> >>>> >>>>> Belay that review.. I have some (significant) changes to make, in >>>>> preparation for the larger task of implementing the AVFoundation based >>>>> code. >>>>> >>>>> -DrD- >>>>> >>>>> >>>>> >>>>>> JIRA: >>>>>> >>>>>> https://javafx-jira.kenai.com/browse/RT-38074 >>>>>> >>>>>> >>>>>> Webrev: >>>>>> >>>>>> http://cr.openjdk.java.net/~ddehaven/RT-38074/rt.0/ >>>>>> >>>>>> >>>>>> This change moves the QTKit based media platform code into it's own >>>>>> dylib. NativeMediaManager had to be modified to allow detection of the >>>>>> new library to determine if the platform was available or not. There may >>>>>> be a slight performance impact due to loading the native libs sooner, >>>>>> but the bulk of the initialization is still done at a later time. >>>>>> >>>>>> -DrD- >>>>>> >>>>>> >>>>>> >> >> >>
