http://cr.openjdk.java.net/~kcr/8170701/webrev.01/


Kevin Rushforth wrote:


Mandy Chung wrote:
On Mar 3, 2017, at 10:29 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> wrote:

Please review the following to update the FXML docs to document the requirement for a module that annotates non-public members with @FXML to "open" the containing package to the javafx.fxml module.

https://bugs.openjdk.java.net/browse/JDK-8170701
http://cr.openjdk.java.net/~kcr/8170701/webrev.00/

The doc change looks fine to me.

Minor suggestion. You may refer "module-info class” to {@link ModuleDescriptor} which can be synthesized (although it may not be common).

I'll make this change.

You may consider referencing {@link Module#isOpened} where you may say “the containing package of the object is {@link Module#isOpened opened} to {@code javafx.fxml} module.

Good idea I will do that.

I'll post an updated webrev.

-- Kevin

Mandy

Reply via email to