> On Apr 18, 2017, at 12:48 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > > > Alan Bateman wrote: >> >> >> On 18/04/2017 19:19, Kevin Rushforth wrote: >>> Good suggestion. Here is an updated webrev with Mandy's suggestion and >>> yours: >>> >>> http://cr.openjdk.java.net/~kcr/8178015/webrev.01/ >>> >>> -- Kevin >> This looks mostly okay. >> >> I guess for FXML then I assume that the annotated member could be public, in >> which case the package just needs to be exported (no need to open). > > Yes, it could be, but the more typical use of the annotation is on non-public > members, so that was why I chose that as the example.
I have the same comment as Alan. The example in the javadoc may be perceived as a recommendation. We should probably recommend the annotated member be moved to public and encapsulated in its module, just exports it to javafx.fxml to use. Mandy
