On Fri, 20 Dec 2019 14:03:02 GMT, Ambarish Rapte <[email protected]> wrote:
>> OK, so we're in agreement on the fix itself. Good.
>>
>> The existing logging done right before the function returns will indeed log
>> a complete failure to find a valid pixel format. It won't, however, log the
>> fact that the initial attempt failed and we then try to use a fallback. It
>> was this that @arapte asked to be logged. I agree with his request.
>
> It looks good then, please update PR without `err != kCGLNoError`
Something like this, maybe?
if (pix == NULL) {
NSLog(@"CGLChoosePixelFormat: unable to find a pixel format, trying
again with reduced capabilities");
The message could perhaps be improved, but something indicating we are using a
fallback would be helpful.
-------------
PR: https://git.openjdk.java.net/jfx/pull/65
