On Fri, 20 Dec 2019 14:06:30 GMT, Kevin Rushforth <[email protected]> wrote:
>> It looks good then, please update PR without `err != kCGLNoError`
>
> Something like this, maybe?
>
> if (pix == NULL) {
> NSLog(@"CGLChoosePixelFormat: unable to find a pixel format, trying
> again with reduced capabilities");
>
> The message could perhaps be improved, but something indicating we are using
> a fallback would be helpful.
> The existing logging done right before the function returns will indeed log a
> complete failure to find a valid pixel format. It won't, however, log the
> fact that the initial attempt failed and we then try to use a fallback. It
> was this that @arapte asked to be logged. I agree with his request.
Agreed.
I suggest the printout only explains that we failed to get a pixel format
object and we're about to try again but doesn't mention the returned error;
since we don't check on its value, we could end up printing something like
"Failed to do something very important[..] (Error: No error)", which would just
be confusing IMO.
-------------
PR: https://git.openjdk.java.net/jfx/pull/65
