On Fri, 20 Dec 2019 22:19:27 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232589 >> >> - Removed CoreAudio Utility classes. >> - Spectrum which was depended on CoreAudio Utility classes for doing >> computations will now run GStreamer spectrum element to do spectrum. Element >> will be run without pipeline and will be used as utility library to do >> spectrum calculation. I added extra APIs to bypass proper element >> initialization. >> - Equalizer and audio unit (volume and balance) where modified, so we can >> run then directly without CoreAudio pipeline. > > modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c > line 915: > >> 914: bpf = GST_AUDIO_FILTER_BPF (spectrum); >> 915: #ifdef OSX >> 916: if (spectrum->bps_user != 0 && spectrum->bpf_user != 0) { > > Should this also be qualified with `GSTREAMER_LITE` since it represents > changes specific to our port? It doesn't look required to me, but it would make more sense and bring it at the same level as line 738 ------------- PR: https://git.openjdk.java.net/jfx/pull/69
