On Wed, 1 Jan 2020 19:16:33 GMT, Johan Vos <j...@openjdk.org> wrote:
>> modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c
>> line 915:
>>
>>> 914: bpf = GST_AUDIO_FILTER_BPF (spectrum);
>>> 915: #ifdef OSX
>>> 916: if (spectrum->bps_user != 0 && spectrum->bpf_user != 0) {
>>
>> Should this also be qualified with `GSTREAMER_LITE` since it represents
>> changes specific to our port?
>
> true, as spectrum->bps_user has #if defined (GSTREAMER_LITE) && defined (OSX)
> around its definition.
>
> Even apart from that, it would make more sense and bring it at the same level
> as line 738
No need for GSTREAMER_LITE, since this code already inside #ifdef
GSTREAMER_LITE. See line 885 and 925.
-------------
PR: https://git.openjdk.java.net/jfx/pull/69
