On Fri, 3 Jan 2020 05:08:33 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 43:
>
>> 42: private static final double DEFAULT_MAX_RANGE =
>> Double.POSITIVE_INFINITY;
>> 43:
>> 44: public NGPointLight() {
>
> Will it be a good idea to move these constants to `PointLight` class?
> However they look good here too.
If they are in `PointLight` it will be difficult for the peer to access them
(will need to do through the accessor). Also, the parent `NGLightBase` holds
the defaults for `color` and `lightOn`.
-------------
PR: https://git.openjdk.java.net/jfx/pull/43
