On Tue, 21 Jan 2020 18:02:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Updated GTK Webkit 2.26 (609.1) into jfx. > > A sanity check of the patch looks good to me: I did a build / test on all > three platforms. I'll do a bit more testing, and also review the > JavaFX-specific files, before completing my review. > > To the latter point, I took the patch, applied it to my personal fork, and > then split it into two commits, one of which has the changes to the files > that I wanted to take a closer look at (finding just those files in the > original PR when there are over 5,000 files would be impractical -- > impossible given GitHub's 3000 file limitation in the file diff veiwer). > > In case this is useful to other reviewers, [click > here](https://github.com/kevinrushforth/jfx/compare/fa6df1ecacc1334b256ffd96dd15cd7dfb1fc108...83d114aed6f9f30ebd90a567192537f62328ffa5) > for the diffs. It only includes 87 files, many of which are cmake files for > platforms other than `Java` so don't really need to be reviewed. This will need at least two reviewers, including myself and @johanvos ------------- PR: https://git.openjdk.java.net/jfx/pull/91
