On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb <g...@openjdk.org> wrote:

> Updated GTK Webkit 2.26 (609.1) into jfx.

Everything looks good to me.

Here are a couple things I noticed that may warrant a follow-up issue to 
address them:

1. Unimplemented methods:
    * FileSystemJava.cpp:
        * truncateFile
        * MappedFileData::MappedFileData
        * MappedFileData::mapFileHandle
        * unmapViewOfFile
    * FrameLoaderClientJava.cpp:
        * didSaveToPageCache
        * didRestoreFromPageCache

2. General cleanup:
    * PageCacheJava.cpp:
       // FIXME: Openjfx2.26 rename pagecache to backforwardcache

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/91

Reply via email to