Yeah, he did. ;)
On 22.02.2020 17:58, Kevin Rushforth wrote:
You should be all set now. Dalibor will likely take care of this early
next week.
-- Kevin
On 2/22/2020 8:42 AM, Rony G. Flatscher wrote:
On 22.02.2020 17:33, Philip Race wrote:
What openjdk ID would this be associated with ?
8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with
FILENAME and ARGV #122
One PR is the fix another one is dubbed as WIP and has the test unit
for this bug (such that one can
apply it before and after the fix).
I don't see a Rony Flatscher in the census :
https://openjdk.java.net/census
Rony, Have you made contributions and been granted author status ?
No, this is the first time I try to contribute code.
If yes, where is it on that page ? If not, then you need to make
contributions
(not just sign the OCA) before you get author status and until then
there is nothing
with which to associate your github id.
Hmm, how should I then submit a fix/a pull request?
The OCA was processed in 2017-03-01 (reported by Dalibor Topic), as
suggested I introduced myself in
[1]. However, for various reasons I got side tracked and only came
back this last November.
@Kevin: thank you for your advice, did comment on both PR
---rony
[1] "Introduction":
<https://mail.openjdk.java.net/pipermail/discuss/2017-March/004160.html>
On 2/22/20, 8:27 AM, Kevin Rushforth wrote:
What you need to do is this:
Once you have signed the OCA, please let us know by writing
`/signed` in a comment in this pull
request.
Omit the quotes in the command.
This will alert the Skara maintainers to check your OCA status and
make the association.
-- Kevin
On 2/22/2020 8:20 AM, Rony G. Flatscher wrote:
Trying to place my first pull requests via github and received the
following e-mail:
--- cut ---
Hi ronyfla, welcome to this OpenJDK project and thanks for
contributing!
We do not recognize you as Contributor
<https://openjdk.java.net/bylaws#contributor> and need to
ensure you have signed the Oracle Contributor Agreement (OCA). If
you have not signed the OCA,
please follow the instructions
<https://www.oracle.com/technetwork/community/oca-486395.html>.
Please fill in your GitHub username in the "Username" field of the
application. Once you have
signed
the OCA, please let us know by writing |/signed| in a comment in
this pull request.
If you already are an OpenJDK Author
<https://openjdk.java.net/bylaws#author>, Committer
<https://openjdk.java.net/bylaws#committer> or Reviewer
<https://openjdk.java.net/bylaws#reviewer>,
please click here
<https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1>
to
open a new issue so that we can record that fact. Please use "Add
GitHub user ronyfla" as summary
for the issue.
If you are contributing this work on behalf of your employer and
your employer has signed the OCA,
please let us know by writing |/covered| in a comment in this pull
request.
--- cut ---
So I am kindly requesting to associate my github user id 'ronyfla'
with my signed OCA form such
that
the pull requests can go forward.
TIA
---rony
P.S.: In the meantime I have changed the github e-mail address for
'ronyfla' to the one in the OCA
if that makes a difference.
--
<http://www.oracle.com> Dalibor Topic
Consulting Product Manager
Phone: +494089091214 <tel:+494089091214>, Mobile: +491737185961
<tel:+491737185961>, Video: dalibor.to...@oracle.com
<sip:dalibor.to...@oracle.com>
Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann
