The importance of 05afad6 Is there in the commit itself: + // + // One idiom employed by developers is to, during the layout pass, + // add or remove nodes from the scene. For example, a ScrollPane + // might add scroll bars to itself if it determines during layout + // that it needs them, or a ListView might add cells to itself if + // it determines that it needs to. In such situations we must + // apply the CSS immediately and not add it to the scene's queue + // for deferred action. +
If you revert 05afad6, you'll break this. This is the first time I've become aware of this flickering issue. I'll have to look at it. I wonder if the fix for https://bugs.openjdk.java.net/browse/JDK-8193445 has any impact on this. > -----Original Message----- > From: openjfx-dev <openjfx-dev-boun...@openjdk.java.net> On Behalf Of > Danny Gonzalez > Sent: Tuesday, March 3, 2020 11:14 AM > To: openjfx-dev@openjdk.java.net > Subject: [EXTERNAL] JDK-8177945 : Single cell selection flickers when adding > data to TableView > > > There is currently an open bug to do with the issue of selection flickering > when using single cell selection and when adding data to a TableView. > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs > .java.com%2Fbugdatabase%2Fview_bug.do%3Fbug_id%3D8177945&da > ta=02%7C01%7Cdavid.grieve%40microsoft.com%7C91a16d9ab05340719f3008 > d7bf8e3410%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63718848 > 9816399816&sdata=wdPRh3VnN%2BfJw%2BatKOyBi9%2Ba2%2FidMJJb > 8AwcRXVrfLo%3D&reserved=0 > > This bug seems to be low priority because it hasn’t been looked at since I > submitted it at the start of 2017. > > This is quite a major issue for us so I have narrowed down when the issue > was first introduced. > > Here is the changeset: > > commit 05afad6b528e871d607b76aea2642cf788b417fe > Author: David Grieve > <dgri...@openjdk.org<mailto:dgri...@openjdk.org>> > Date: Tue Apr 15 11:51:38 2014 -0400 > > RT-36672: move code to process css during layout back to impl_reapplyCSS, > which is where it was priort to RT-36559 > > > I can’t search the bug database for this bug ID as I believe it was submitted > when a previous bug tracking system was in use. > > Does anyone have any knowledge as to why this fix was needed and what > the repercussions would be if I reverted it out for our local OpenJFX build. > > Alternatively I would be glad to receive any suggestions of how to fix the > flickering issue if this changeset is important to leave in. > > Thanks > > Danny
