On Fri, 13 Mar 2020 17:26:35 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid useless width and height calculation > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java > line 1576: > >> 1575: // Find out it is is possible to divide up the >> image in tiles of the same size >> 1576: AtomicBoolean exactWidthDivFound = new >> AtomicBoolean(false); >> 1577: int tileWidth = computeOptimumTileSize(w, >> maxTextureSize, exactWidthDivFound); > > `exactWidthDivFound` is unused, may be can skip creating a named variable and > just pass a unnamed `AtomicBoolean` in > next call to `computeOptimumTileSize` I've made a change so that null can be passed to the method if the AtomicBoolean instance is not needed. ------------- PR: https://git.openjdk.java.net/jfx/pull/112
